Nitro validation client connects to the Rust validation server#4450
Merged
Nitro validation client connects to the Rust validation server#4450
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4450 +/- ##
==========================================
+ Coverage 32.72% 34.70% +1.98%
==========================================
Files 493 493
Lines 58290 58290
==========================================
+ Hits 19076 20231 +1155
+ Misses 35868 34475 -1393
- Partials 3346 3584 +238 |
Contributor
❌ 11 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
bragaigor
requested changes
Mar 3, 2026
Contributor
bragaigor
left a comment
There was a problem hiding this comment.
LGTM overall, just a few minor comments
eljobe
approved these changes
Mar 6, 2026
Member
eljobe
left a comment
There was a problem hiding this comment.
Nice. Very clear PR description that made it easier to review the code. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Nitro validation client uses JSON RPC communication, we actually have to abandon nice HTTP path-based routing in favor of a single root dispatcher, that inspects the
methodfield in the JSON RPC envelope.This PR makes necessary changes and adds a system test, where we create a validation client object (Nitro native component) connected to a running Rust validation service and ensure that the two communicate properly.
Next steps:
axumto a simplerjsonrpsee(dedicated for JSON RPC) server backend; this is not critical, becauseaxumworks well and has nice integrations (e.g. for tracing), but we actually don't need all its capabilitiescloses NIT-4594