Prevent MEL node startup if have non-MEL entries in ConsensusDB#4449
Open
ganeshvanahalli wants to merge 2 commits intoraul/mel-pr3-corefrom
Open
Prevent MEL node startup if have non-MEL entries in ConsensusDB#4449ganeshvanahalli wants to merge 2 commits intoraul/mel-pr3-corefrom
ganeshvanahalli wants to merge 2 commits intoraul/mel-pr3-corefrom
Conversation
bragaigor
reviewed
Mar 2, 2026
Contributor
bragaigor
left a comment
bragaigor
left a comment
There was a problem hiding this comment.
LGTM, just a few minor comments
Contributor
❌ 7 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## raul/mel-pr3-core #4449 +/- ##
=====================================================
- Coverage 29.19% 29.15% -0.04%
=====================================================
Files 493 493
Lines 58577 58608 +31
=====================================================
- Hits 17099 17087 -12
- Misses 38374 38414 +40
- Partials 3104 3107 +3 |
bragaigor
assigned
ganeshvanahalli and
diegoximenes and unassigned
bragaigor and
ganeshvanahalli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it that If the inbox tracker / reader have DB values (meaning a node was started in non-MEL mode), we should error on startup if we enable the MEL flag.
Resolves NIT-4571