Prechecker address filtering, mirrors DelayedFilteringSequencingHooks.PostTxFilter by MishkaRogachev · Pull Request #4444 · OffchainLabs/nitro

MishkaRogachev · 2026-03-02T10:46:06Z

Base filtring scenarios
Redeem scheduled transactions
Refactor duplication from preCheckAddressFilter

Tests and wiring from #4382

….PostTxFilter

codecov · 2026-03-02T15:36:44Z

Codecov Report

❌ Patch coverage is 15.09434% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.77%. Comparing base (0935545) to head (27f5611).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4444      +/-   ##
==========================================
- Coverage   34.67%   32.77%   -1.91%     
==========================================
  Files         493      493              
  Lines       58290    58393     +103     
==========================================
- Hits        20212    19137    -1075     
- Misses      34493    35916    +1423     
+ Partials     3585     3340     -245

github-actions · 2026-03-02T16:14:17Z

❌ 11 Tests Failed:

Tests completed	Failed	Passed	Skipped
4243	11	4232	0

View the top 3 failed tests by shortest run time

TestEndToEnd_ManyEvilValidators

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207508
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

goroutine 5604568 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xd9
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207514
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

goroutine 5604654 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xd9
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207502
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

goroutine 5604644 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xd9
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207502
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

TestEndToEnd_ManyEvilValidators/honest_essential_edges_confirmed_by_challenge_win

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207508
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

goroutine 5604568 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xd9
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207514
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

goroutine 5604654 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xd9
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207502
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

goroutine 5604644 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xd9
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 207502
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:106 +0x10a

TestVersion30

Stack Traces | 6.270s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-03|10:48:07.337] Writing cached state to disk             block=1  hash=c0e669..e2ff8a root=8448b4..050cee
INFO [03-03|10:48:07.337] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=541ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-03|10:48:07.337] Writing snapshot state to disk           root=6b754c..7398ca
INFO [03-03|10:48:07.337] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=952ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-03|10:48:07.337] Updated payload                          id=0x03946cb56d150a57 number=23 hash=473b42..ad90e5 txs=1  withdrawals=0 gas=2,140,175  fees=2.140175e-06  root=8dd346..a0d928 elapsed="740.643µs"
INFO [03-03|10:48:07.337] Blockchain stopped
WARN [03-03|10:48:07.337] Served eth_call                          reqid=11  duration=5.256608079s err="execution aborted (timeout = 5s)"
--- FAIL: TestVersion30 (6.27s)
INFO [03-03|10:48:07.338] Stopping work on payload                 id=0x03946cb56d150a57 reason=delivery
INFO [03-03|10:48:07.338] Writing cached state to disk             block=1  hash=49b0bf..267b43 root=d45d64..4e7811
INFO [03-03|10:48:07.338] addresss table import complete
INFO [03-03|10:48:07.339] retryables import complete
INFO [03-03|10:48:07.339] Persisted trie from memory database      nodes=23  flushnodes=0 size=3.61KiB   flushsize=0.00B time="127.368µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.352µs"   livenodes=0    livesize=0.00B
INFO [03-03|10:48:07.339] Writing cached state to disk             block=1  hash=49b0bf..267b43 root=d45d64..4e7811
INFO [03-03|10:48:07.339] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=481ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-03|10:48:07.339] Writing snapshot state to disk           root=28fb26..40a768
INFO [03-03|10:48:07.339] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=361ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-03|10:48:07.339] Imported new potential chain segment     number=23 hash=473b42..ad90e5 blocks=1  txs=1  mgas=2.140  elapsed=1.533ms     mgasps=1395.902 triediffs=85.62KiB  triedirty=0.00B
INFO [03-03|10:48:07.339] Blockchain stopped
INFO [03-03|10:48:07.339] Chain head was updated                   number=23 hash=473b42..ad90e5 root=8dd346..a0d928 elapsed="265.837µs"

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

MishkaRogachev · 2026-03-03T16:21:13Z

execution/gethexec/tx_pre_checker.go

+			touchFilterAddresses(statedb, c.eventFilter, tx, sender)
+
+			// Touch addresses from scheduled retry txes (redeems).
+			for _, scheduledTx := range result.ScheduledTxes {


Note: should support cascading redeems, #4436

MishkaRogachev added 2 commits March 2, 2026 15:58

Prechecker address filtering, mirrors DelayedFilteringSequencingHooks…

494c6ba

….PostTxFilter

Support redeems filtering in preCheckAddressFilter

a07f255

MishkaRogachev force-pushed the prefilter-blockchain-api branch from 27d381b to a07f255 Compare March 2, 2026 15:02

Refactor address touching in execution path to reuse in prechecker

27f5611

MishkaRogachev marked this pull request as ready for review March 3, 2026 10:41

MishkaRogachev requested review from Tristan-Wilson and diegoximenes March 3, 2026 10:41

MishkaRogachev assigned Tristan-Wilson Mar 3, 2026

MishkaRogachev commented Mar 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prechecker address filtering, mirrors DelayedFilteringSequencingHooks.PostTxFilter#4444

Prechecker address filtering, mirrors DelayedFilteringSequencingHooks.PostTxFilter#4444
MishkaRogachev wants to merge 3 commits intomasterfrom
prefilter-blockchain-api

MishkaRogachev commented Mar 2, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

MishkaRogachev Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MishkaRogachev commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 11 Tests Failed:

Uh oh!

MishkaRogachev Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MishkaRogachev commented Mar 2, 2026 •

edited

Loading

codecov bot commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading