Skip to content

Refactor ArbOSVersionGetter interface#4438

Open
pmikolajczyk41 wants to merge 6 commits intopmikolajczyk/nit-4062-execution-sequencerfrom
pmikolajczyk/nit-4523-interface
Open

Refactor ArbOSVersionGetter interface#4438
pmikolajczyk41 wants to merge 6 commits intopmikolajczyk/nit-4062-execution-sequencerfrom
pmikolajczyk/nit-4523-interface

Conversation

@pmikolajczyk41
Copy link
Member

To follow the same pattern of other Execution interface behaviors:

  • Removed ArbOSVersionGetter from ExecutionClient
  • Renamed ArbOSVersionGetter interface to ExecutionBatchPoster
  • Added ExecutionBatchPoster to FullExecutionClient

closes NIT-4523

@pmikolajczyk41 pmikolajczyk41 changed the title Pmikolajczyk/nit 4523 interface Refactor ArbOSVersionGetter interface Feb 27, 2026
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.72%. Comparing base (783ccce) to head (ff45de8).

Additional details and impacted files
@@                              Coverage Diff                              @@
##           pmikolajczyk/nit-4062-execution-sequencer    #4438      +/-   ##
=============================================================================
- Coverage                                      32.77%   32.72%   -0.05%     
=============================================================================
  Files                                            494      494              
  Lines                                          58338    58338              
=============================================================================
- Hits                                           19119    19093      -26     
- Misses                                         35879    35896      +17     
- Partials                                        3340     3349       +9     

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
4233 7 4226 0
View the top 3 failed tests by shortest run time
TestNitroNodeVersionAlerter
Stack Traces | 0.910s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [02-27|15:10:26.680] Chain head was updated                   number=38  hash=cf612e..566e11 root=a45df5..932caf elapsed="65.893µs"
INFO [02-27|15:10:26.680] Starting work on payload                 id=0x03ac8aa9abc292b0
INFO [02-27|15:10:26.681] Imported new potential chain segment     number=4   hash=1f592f..68c702 blocks=1  txs=1  mgas=4.765  elapsed=11.801ms     mgasps=403.795  triediffs=12.11KiB  triedirty=0.00B
INFO [02-27|15:10:26.682] Chain head was updated                   number=4   hash=1f592f..68c702 root=493b56..c9de84 elapsed="405.465µs"
INFO [02-27|15:10:26.687] created block                            l2Block=1 l2BlockHash=4d7251..2808aa
INFO [02-27|15:10:26.695] Submitted transaction                    hash=0x886aa253584ac1f6d00f1860f65f38eaac539fd1f311757f5f6ac50bc0355e69 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=24 recipient=0xB211efa485d87C29b9486E7631D3140e16D28E08 value=0
INFO [02-27|15:10:26.699] Starting work on payload                 id=0x03fe3bd53eee21f3
INFO [02-27|15:10:26.702] Submitted transaction                    hash=0x2431a1d0d18e2a6cce60929111dfb3105013e87da054e131bd52a33ee7aafaec from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=25 recipient=0x4C4Ac1257945782bf52A724e75687d9010C770DE value=0
INFO [02-27|15:10:26.702] Deploying seq inbox bufferable
INFO [02-27|15:10:26.708] Submitted transaction                    hash=0xc9821b430dd62dc5de808e57f54e1ce668ce11150fbc4fee9b9a43f963d62349 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=0  recipient=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 value=1
INFO [02-27|15:10:26.709] Submitted transaction                    hash=0xa98aafc2fec373ceb83b4f244342d0f62d37f88dd378787000a0c3c7bc4d54fd from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=0  recipient=0x00000000000000000000000000000000000000ff value=0
INFO [02-27|15:10:26.717] Starting work on payload                 id=0x032ce9d83fb4f906
INFO [02-27|15:10:26.718] Submitted transaction                    hash=0xa51b14cecba72f8a8ff1150aad815080de57af4b94db9fc569a22398d60cce6f from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=28 recipient=0x4C4Ac1257945782bf52A724e75687d9010C770DE value=0
INFO [02-27|15:10:26.718] Starting work on payload                 id=0x03f1c7e388c1424a
INFO [02-27|15:10:26.718] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.7
WARN [02-27|15:10:26.718] P2P server will be useless, neither dialing nor listening
INFO [02-27|15:10:26.719] Starting work on payload                 id=0x0365dab33349a256
INFO [02-27|15:10:26.719] Starting work on payload                 id=0x03867f580f28330d
WARN [02-27|15:10:26.721] Getting file info                        dir= error="stat : no such file or directory"
--- FAIL: TestNitroNodeVersionAlerter (0.91s)
TestRedisProduceComplex/one_producer,_all_consumers_are_active
Stack Traces | 1.310s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[02-27|15:00:45.478] Redis stream consuming                   �[36mconsumer_id�[0m=72092407-7af2-442f-977d-226aaed40ffb �[36mmessage_id�[0m=1772204444322-1
�[36mDEBUG�[0m[02-27|15:00:45.478] consumer: setting result                 �[36mcid�[0m=72092407-7af2-442f-977d-226aaed40ffb �[36mmsgIdInStream�[0m=1772204444322-1  �[36mresultKeyInRedis�[0m=result-key:stream:7c228303-034f-4779-8bc0-ffa84a1eb521.1772204444322-1
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444320-1
�[36mDEBUG�[0m[02-27|15:00:45.479] consumer: xdel                           �[36mcid�[0m=c24a910c-0f0f-433b-87c6-dadb19218d20 �[36mmessageId�[0m=1772204444319-2
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444320-2
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444321-0
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444321-1
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444322-0
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444322-2
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444342-0
�[33mWARN �[0m[02-27|15:00:45.479] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444342-2
�[36mDEBUG�[0m[02-27|15:00:45.480] consumer: xack                           �[36mcid�[0m=72092407-7af2-442f-977d-226aaed40ffb �[36mmessageId�[0m=1772204444322-1
�[33mWARN �[0m[02-27|15:00:45.480] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444317-1
�[36mDEBUG�[0m[02-27|15:00:45.480] consumer: xdel                           �[36mcid�[0m=72092407-7af2-442f-977d-226aaed40ffb �[36mmessageId�[0m=1772204444322-1
�[33mWARN �[0m[02-27|15:00:45.483] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444322-1
�[33mWARN �[0m[02-27|15:00:45.483] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1772204444342-3
�[36mDEBUG�[0m[02-27|15:00:45.577] checkResponses                           �[36mresponded�[0m=77 �[36merrored�[0m=0 �[36mchecked�[0m=78
�[36mDEBUG�[0m[02-27|15:00:45.584] redis producer: check responses starting
�[31mERROR�[0m[02-27|15:00:45.592] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="NOGROUP No such key 'stream:7c228303-034f-4779-8bc0-ffa84a1eb521' or consumer group 'stream:7c228303-034f-4779-8bc0-ffa84a1eb521'" �[31mpendingLen�[0m=0
--- FAIL: TestRedisProduceComplex/one_producer,_all_consumers_are_active (1.31s)
TestVersion30
Stack Traces | 6.820s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [02-27|15:08:21.624] Stopping work on payload                 id=0x0356a84c8e8e92a8 reason=delivery
INFO [02-27|15:08:21.624] Imported new potential chain segment     number=469 hash=00e3df..0de4e6 blocks=1  txs=1  mgas=0.021  elapsed=22.487ms     mgasps=0.934    triediffs=640.14KiB  triedirty=229.02KiB
INFO [02-27|15:08:21.625] Chain head was updated                   number=469 hash=00e3df..0de4e6 root=57768b..fb2c57 elapsed="60.233µs"
INFO [02-27|15:08:21.626] Submitted contract creation              hash=0x61f78ed7484d562ec25d752a5b868d87786cc5c21bd3482b81469d671a2b4197 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=1    contract=0xC0d44eBf2024FAa79d5aa2F2b1a19329E53a8a77 value=0
INFO [02-27|15:08:21.626] Submitted contract creation              hash=0x590a714c5f270b6dff98907bbb609f533e0b51e931dd08ec097069c24356040e from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=5    contract=0x921D7e54132EeC49687ac00C3cEFAa7ACD6dfD86 value=0
INFO [02-27|15:08:21.631] Starting work on payload                 id=0x03f1b34347e75949
INFO [02-27|15:08:21.631] Writing cached state to disk             block=1   hash=101bb1..e7634e root=d45d64..4e7811
INFO [02-27|15:08:21.635] Persisted trie from memory database      nodes=23  flushnodes=0 size=3.61KiB   flushsize=0.00B time="150.552µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="2.143µs"  livenodes=0    livesize=0.00B
INFO [02-27|15:08:21.635] Writing cached state to disk             block=1   hash=101bb1..e7634e root=d45d64..4e7811
INFO [02-27|15:08:21.635] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=592ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [02-27|15:08:21.635] Writing snapshot state to disk           root=28fb26..40a768
INFO [02-27|15:08:21.635] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=341ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [02-27|15:08:21.635] Blockchain stopped
INFO [02-27|15:08:21.636] Updated payload                          id=0x03f1b34347e75949 number=922 hash=b97757..477c3a txs=1  withdrawals=0 gas=140,833    fees=0.000704165    root=1c6675..9180cd elapsed=2.750ms
INFO [02-27|15:08:21.636] Stopping work on payload                 id=0x03f1b34347e75949 reason=delivery
INFO [02-27|15:08:21.631] Imported new potential chain segment     number=741 hash=3c93ff..8a2400 blocks=1  txs=1  mgas=0.021  elapsed=12.974ms     mgasps=1.619    triediffs=665.64KiB  triedirty=368.75KiB
INFO [02-27|15:08:21.639] Chain head was updated                   number=741 hash=3c93ff..8a2400 root=3e63b9..7ccc54 elapsed="63.068µs"
INFO [02-27|15:08:21.636] Submitted transaction                    hash=0x840a55fad24b72b6fa4bed3018302f3b4d5789d0ed2e3e917b69ffcaec470903 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=15   recipient=0xBe9AEc078A7E128A8FE1e64334D61cf38a5D3705 value=1,000,000,000,014
INFO [02-27|15:08:21.627] Starting work on payload                 id=0x03d1715cd1c39f0d
--- FAIL: TestVersion30 (6.82s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@pmikolajczyk41 pmikolajczyk41 marked this pull request as ready for review February 27, 2026 18:09
Copy link
Contributor

@bragaigor bragaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bragaigor bragaigor assigned eljobe and unassigned bragaigor Feb 28, 2026
@eljobe
Copy link
Member

eljobe commented Mar 3, 2026

Sorry. I vaguely remember that there was some reason that @diegoximenes had wanted to use a something less than a FullExecutionClient there. So, I'd like his seal of approval before I "design-approved" this one.

@eljobe eljobe assigned diegoximenes and unassigned eljobe Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants