Refactor ArbOSVersionGetter interface#4438
Open
pmikolajczyk41 wants to merge 6 commits intopmikolajczyk/nit-4062-execution-sequencerfrom
Open
Refactor ArbOSVersionGetter interface#4438pmikolajczyk41 wants to merge 6 commits intopmikolajczyk/nit-4062-execution-sequencerfrom
pmikolajczyk41 wants to merge 6 commits intopmikolajczyk/nit-4062-execution-sequencerfrom
Conversation
…cutionClient - no harm, we pass there full client anyway
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## pmikolajczyk/nit-4062-execution-sequencer #4438 +/- ##
=============================================================================
- Coverage 32.77% 32.72% -0.05%
=============================================================================
Files 494 494
Lines 58338 58338
=============================================================================
- Hits 19119 19093 -26
- Misses 35879 35896 +17
- Partials 3340 3349 +9 |
Contributor
❌ 7 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Member
|
Sorry. I vaguely remember that there was some reason that @diegoximenes had wanted to use a something less than a FullExecutionClient there. So, I'd like his seal of approval before I "design-approved" this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To follow the same pattern of other Execution interface behaviors:
ArbOSVersionGetterfromExecutionClientArbOSVersionGetterinterface toExecutionBatchPosterExecutionBatchPostertoFullExecutionClientcloses NIT-4523