fix: Move ECS CF Generation to Calamari#1971
Merged
Merged
Conversation
Contributor
Jtango18
commented
May 27, 2026
Jtango18
commented
Jtango18
force-pushed
the
jt-ecs-template-builder
branch
2 times, most recently
from
c43cddd to
d639db3
Compare
Jtango18
force-pushed
the
jt-ecs-template-builder
branch
from
698f61e to
a5f739d
Compare
Jtango18
requested review from
APErebus,
sathvikkumar-octo and
zentron
and removed request for
sathvikkumar-octo
Jtango18
force-pushed
the
jt-ecs-template-builder
branch
2 times, most recently
from
bbfd24c to
513f63e
Compare
Jtango18
force-pushed
the
jt-ecs-template-builder
branch
from
513f63e to
31f24c5
Compare
New implementation consumes they existing Deploy CF Template command and we test all the other pieces around that. This test provides very little additional value
|
|
||
| [TestFixture] | ||
| [Category(TestCategory.RunOnceOnWindowsAndLinux)] | ||
| public class DeployEcsServiceFixture |
Contributor
There was a problem hiding this comment.
Fair bit of work to update this but I recall this was the only test that hit AWS at all so we have lost some coverage
Contributor
Author
There was a problem hiding this comment.
It tested "Does out code create a CF template when we call it". We have a test already that does that, the specifics for this are around the uniqueness of a an ECS template which is all tested and validated elsewhere.
APErebus
reviewed
Jun 2, 2026
APErebus
approved these changes
Jun 3, 2026
Contributor
APErebus
left a comment
APErebus
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for addressing the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.