Move Argo file changes stuff into Calamari contracts#1914
Merged
Conversation
…amari into frank/contracts # Conflicts: # source/Calamari.Contracts/ArgoCD/ArgoCDCustomPropertiesDto.cs
flin-8
commented
Jun 2, 2026
| } | ||
|
|
||
| List<TrackedSourceDetail> ConvertPathsToPosix(List<TrackedSourceDetail> inputs) | ||
| static SourceFileChanges MapSource(TrackedSourceDetail trackedSourceDetail) |
Contributor
Author
There was a problem hiding this comment.
Decouple the service message source details from the TrackedSourceDetail (we will add more stuff to TrackedSourceDetail in a later PR)
flin-8
changed the title
APErebus
reviewed
Jun 3, 2026
| using NSubstitute; | ||
| using NUnit.Framework; | ||
| using Octopus.Calamari.Contracts.ArgoCD; | ||
| using FileJsonPatch = Calamari.ArgoCD.FileJsonPatch; |
Contributor
There was a problem hiding this comment.
Why use the old one and not the new contracts one?
zentron
approved these changes
Jun 3, 2026
Contributor
zentron
left a comment
zentron
left a comment
There was a problem hiding this comment.
Just a non-blocking question about the using statement
| using NSubstitute; | ||
| using NUnit.Framework; | ||
| using Octopus.Calamari.Contracts.ArgoCD; | ||
| using FileJsonPatch = Calamari.ArgoCD.FileJsonPatch; |
Contributor
There was a problem hiding this comment.
Why do we need to set this using? shouldnt the change result in only one FileJsonPatch in the solution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so we can share the service message names etc. with Server
Relates to MD-1901: Support the same application name in different namespaces