feat: Add Bandit pre-commit hook + fix XML parsing vulnerability (#2417)#2421
Merged
sydseter merged 2 commits intoOWASP:masterfrom Feb 27, 2026
Merged
Conversation
khushal-winner
force-pushed
the
feat/add-bandit-pre-commit-hook
branch
3 times, most recently
from
314aa7c to
d9855c0
Compare
khushal-winner
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
khushal-winner
force-pushed
the
feat/add-bandit-pre-commit-hook
branch
2 times, most recently
from
96bca83 to
9cf9b0f
Compare
- Add bandit pre-commit hook to scan Python scripts for security issues - Configure bandit to scan scripts/ directory with medium severity and high confidence - Fix XML parsing vulnerability in convert.py by using defusedxml - Update bandit to version 1.9.4 for Python 3.14 compatibility - Add documentation for security scanning under Contributing to Development section Security improvements: - Replaces unsafe xml.etree.ElementTree.parse with defusedxml.ElementTree.parse - Prevents XML external entity (XXE) attacks - Bandit hook will catch future security regressions Signed-off-by: Khushal Malhotra <redmi5a3217@gmail.com>
khushal-winner
force-pushed
the
feat/add-bandit-pre-commit-hook
branch
from
9cf9b0f to
2af9bae
Compare
Contributor
Author
|
@sydseter, This PR is ready review, Happy to do any further changes, :)) |
sydseter
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2417
Changes
scripts/only (recursive with-r)tests/to avoid false positivesxml.etree.ElementTree.parsewith securedefusedxml.ElementTree.parseinconvert.pyTesting
pre-commit run --all-filespasses locally after fixbandit -r scripts/convert.py --severity-level medium --confidence-level high→ cleanWhy?
Ready for review! Happy to tweak config (e.g. add --exit-zero, skips, bandit.yml) or adjust README.