Skip to content

fix: complete Zip Slip hardening and eliminate BASE_PATH prefix-collision bypass #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashnaaseth2325-oss wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: complete Zip Slip hardening and eliminate BASE_PATH prefix-collision bypass #2409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,10 @@ def _validate_file_paths(source_filename: str, output_pdf_filename: str) -> Tupl

# Ensure paths are within expected directories to prevent path traversal
base_path = os.path.abspath(convert_vars.BASE_PATH)
if not source_path.startswith(base_path):
if not source_path.startswith(base_path + os.sep):
return False, f"Source path outside base directory: {source_path}", ""
if not output_dir.startswith(base_path):

if not output_dir.startswith(base_path + os.sep):
return False, f"Output directory outside base directory: {output_dir}", ""

return True, source_path, output_dir
Expand Down
Loading