Skip to content

Gesture interface merge #181

Open
gfrolov wants to merge 73 commits intomasterfrom
gesture
Open

Gesture interface merge #181
gfrolov wants to merge 73 commits intomasterfrom
gesture

Conversation

@gfrolov
Copy link
Contributor

@gfrolov gfrolov commented Jul 20, 2015

No description provided.

@VRguy VRguy mentioned this pull request Jul 20, 2015
Open
rpavlik
rpavlik reviewed Jul 20, 2015
View reviewed changes
inc/osvr/Common/RegisteredStringMap.h Outdated
Copy link
Member

@rpavlik rpavlik Jul 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooo! Big code guideline violation. (And use an enlargeable structure instead of having a fixed size)

Copy link
Contributor Author

@gfrolov gfrolov Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@zachkinstner
Copy link

zachkinstner commented Aug 18, 2015

Notes about Leap Motion gestures: OSVR/OSVR-Leap-Motion#5

@rpavlik
Copy link
Member

rpavlik commented Aug 18, 2015

The places where an Interface pointer is being held, should instead be using an InternalInterfaceOwner, which was just added to master recently.

@gfrolov
Copy link
Contributor Author

gfrolov commented Sep 9, 2015

This pull request is ready to be merged

@rpavlik
Copy link
Member

rpavlik commented Sep 21, 2015

OK - blocked on #218 - after that is finished (unit tests) and merged, this can be rebased on top of the new master. Most of all the "little" pieces that are independent have been pulled out and merged separately, so there will be ample use of git mergetool during that rebase, but it should result in a more digestable diff. I'd also suggest squashing related commits down into a single commit, especially early in the history where a lot of things changed since then.

@gfrolov
Copy link
Contributor Author

gfrolov commented Sep 23, 2015

I completed unit tests merged #218 yesterday and rebased gesture branch on top of master. Also I fixed a few things that wouldn't let it build and some compiler errors.

@rpavlik
Copy link
Member

rpavlik commented Nov 11, 2015

Will require fix to adjust for 0a63fd5 once that branch is merged. Sorry...

gfrolov and others added 29 commits March 9, 2016 17:33
@gfrolov
add accessor for sys component to joint client context
1652bd3
@gfrolov
misc comment updates
7403fd6
@gfrolov
add gesture remote factory to remote handler
83a61c3
@rpavlik
clang-format
14825b0
@rpavlik
Move and fix the sample config for a gesture server.
39b99e5
@rpavlik
Fix usage error in ClientReportTypes
31014b7
@rpavlik
Fix GestureInterfaceC.h annotations, parameters, and doc.
9303d20
@rpavlik
Substantial simplification of the gesture example
f8e19d6
@rpavlik
Gesture clientkit method name changes and some doc cleanups
db4a545
@rpavlik
Fix configuring of pluginhost - can't put jsoncpp as a public lib.
c0aa2ed
@rpavlik
Substantially overhaul the type-safe ID template.
ac6218b 
No more overriding operator& or providing non-const value accessors
or implicit conversion. It's also now properly in a namespace,
and uses traits classes to determine the underlying value type
as well as the "invalid/empty" sentinel value.
@rpavlik
Work on fixing StringID usages.
2909103
@rpavlik
Fix build
832efd5
@rpavlik
Use the StringBufferBuilder in ClientKit.
6501182
@rpavlik
Work on registered string map
b0af05d
@rpavlik
Some generation of gesture-related files.
8f86845
@rpavlik
Use generated gesture define header.
de03a08
@rpavlik
Gesture and System component changes.
685bdf9
@rpavlik
Add missing file.
e994a6d
@gfrolov
remove unused timestamp param and use updated function names
a0c1d2d
@gfrolov
use updated function names
152d6f2
@gfrolov
minor gesture sample plugin update
58e1746
@gfrolov
use updated function names
943f656
@gfrolov
use sysComponent reference for GestureComponent constructor
08330f3
@gfrolov
disable assignment operator due to reference members which generates …
508c7ac 
…compiler warnings
@gfrolov
remove unused timestamp variable
af47f61
add SystemComponent accessor to AnalysisClientContext
6a18aad
use RemoteHandlerInternals instead of InterfaceList
0d41b05
remove duplicate method, use updated path for include
78de904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gfrolov @zachkinstner @rpavlik