monorepo warning#268
Merged
Merged
Conversation
Contributor
|
Thanks for the PR! Actually, the monorepo pattern was working without troubles when using pnpm, which tool are you using? |
Contributor
Author
|
Bun But the same issue will happen for any package manager that hoists the op-sqlite package to the root node_modules (based on the podspec implementation) |
Contributor
|
Ah bun! Got it! Thanks! |
subtleGradient
pushed a commit
to effect-native/op-sqlite
that referenced
this pull request
Sep 12, 2025
monorepo warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the installation documentation for the
op-sqlitepackage to include important guidance for users working in monorepo environments.Documentation improvements:
docs/docs/installation.md: Added a note explaining that when using a monorepo, the "op-sqlite" configuration must be added to the rootpackage.jsonfile. The note also provides an alternative solution to prevent the package from being hoisted to the rootnode_modulesand suggests checking theios/Podfile.lockfile for installation details.