Skip to content

github-ci: update cov builds from 22.04 to 24.04; --skip-branches#14893

Closed
victorjulien wants to merge 3 commits intoOISF:mainfrom
victorjulien:lcov/1
Closed

github-ci: update cov builds from 22.04 to 24.04; --skip-branches#14893
victorjulien wants to merge 3 commits intoOISF:mainfrom
victorjulien:lcov/1

Conversation

@victorjulien
Copy link
Copy Markdown
Member

Try --skip-branches. Update to 24.04 to make sure we have that option.

@victorjulien victorjulien force-pushed the lcov/1 branch 2 times, most recently from e275e4a to d48b201 Compare February 24, 2026 16:20
@suricata-qa
Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 29871

runmode-af-xdp.c:119:52: error: implicit conversion loses integer precision: 'const int' to 'uint16_t' (aka 'unsigned short') [-Werror,-Wimplicit-int-conversion]
  119 |         aconf->threads = (nr_cores <= nr_queues) ? nr_cores : nr_queues;
      |                        ~                           ^~~~~~~~
runmode-af-xdp.c:119:63: error: implicit conversion loses integer precision: 'const int' to 'uint16_t' (aka 'unsigned short') [-Werror,-Wimplicit-int-conversion]
  119 |         aconf->threads = (nr_cores <= nr_queues) ? nr_cores : nr_queues;
      |                        ~                                      ^~~~~~~~~
runmode-af-xdp.c:135:26: error: implicit conversion loses integer precision: 'const int' to 'uint16_t' (aka 'unsigned short') [-Werror,-Wimplicit-int-conversion]
  135 |         aconf->threads = nr_queues;
      |                        ~ ^~~~~~~~~
runmode-af-xdp.c:268:41: error: implicit conversion loses integer precision: 'intmax_t' (aka 'long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  268 |                 aconf->busy_poll_time = conf_val_int;
      |                                       ~ ^~~~~~~~~~~~
runmode-af-xdp.c:275:43: error: implicit conversion loses integer precision: 'intmax_t' (aka 'long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  275 |                 aconf->busy_poll_budget = conf_val_int;
      |                                         ~ ^~~~~~~~~~~~
runmode-af-xdp.c:282:40: error: implicit conversion loses integer precision: 'intmax_t' (aka 'long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  282 |             aconf->gro_flush_timeout = conf_val_int;
      |                                      ~ ^~~~~~~~~~~~
runmode-af-xdp.c:287:43: error: implicit conversion loses integer precision: 'intmax_t' (aka 'long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  287 |             aconf->napi_defer_hard_irqs = conf_val_int;
      |                                         ~ ^~~~~~~~~~~~
7 errors generated.

source-af-xdp.c:426:24: error: implicit conversion loses integer precision: 'int' to 'uint8_t' (aka 'unsigned char') [-Werror,-Wimplicit-int-conversion]
  426 |     ptv->afxdp_state = state;
      |                      ~ ^~~~~
source-af-xdp.c:642:44: error: implicit conversion loses integer precision: 'uint32_t' (aka 'unsigned int') to '__u16' (aka 'unsigned short') [-Werror,-Wimplicit-int-conversion]
  642 |     ptv->xsk.cfg.bind_flags = afxdpconfig->bind_flags;
      |                             ~ ~~~~~~~~~~~~~^~~~~~~~~~
2 errors generated.
@suricata-qa
Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 29874

@victorjulien
Copy link
Copy Markdown
Member Author

Replaced by #14897

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.92%. Comparing base (ccd1df9) to head (914b94b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14893      +/-   ##
==========================================
+ Coverage   73.26%   81.92%   +8.66%     
==========================================
  Files         993      986       -7     
  Lines      271862   271097     -765     
  Branches    48276    31005   -17271     
==========================================
+ Hits       199177   222094   +22917     
+ Misses      47279    46861     -418     
+ Partials    25406     2142   -23264     
Flag Coverage Δ
fuzzcorpus 61.01% <0.00%> (+3.91%) ⬆️
livemode 18.24% <0.00%> (+2.81%) ⬆️
netns 18.35% <ø> (+2.85%) ⬆️
pcap 45.14% <ø> (+4.27%) ⬆️
suricata-verify 58.49% <ø> (+<0.01%) ⬆️
unittests 58.84% <50.00%> (+8.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants