openbsd: pledge before allowing threads to continue#14826
Closed
victorjulien wants to merge 1 commit intoOISF:mainfrom
Closed
openbsd: pledge before allowing threads to continue#14826victorjulien wants to merge 1 commit intoOISF:mainfrom
victorjulien wants to merge 1 commit intoOISF:mainfrom
Conversation
Avoids a race condition with pcap file directory mode. Ticket: OISF#8300.
|
Information: QA ran without warnings. Pipeline = 29635 |
Contributor
|
How do we test this ? Is this openbsd only ? |
Member
Author
Yes it is OpenBSD only. I've tested in my VMs, but minimally. |
catenacyber
reviewed
Mar 4, 2026
| SC_ATOMIC_SET(engine_stage, SURICATA_RUNTIME); | ||
| PacketPoolPostRunmodes(); | ||
|
|
||
| /* pledge before allowing threads to continue to avoid an issue with pcap file direction mode, |
Contributor
There was a problem hiding this comment.
s/direction/directory/ ?
Contributor
|
Code looks good (besides comment typo)... Should we have an openbsd CI build ? |
Member
Author
Not easy in github-ci I think, but if there is a way I'd be interested. |
Contributor
jasonish
requested changes
Mar 4, 2026
Member
jasonish
left a comment
jasonish
left a comment
There was a problem hiding this comment.
Seems OK. Not sure I 100% understand why moving pledge earlier works though.
Fix typo, I think its a critical one.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids a race condition with pcap file directory mode.
Ticket: #8300.
https://redmine.openinfosecfoundation.org/issues/8300
@eroullit are you able to review this? Thanks!