Open
Conversation
inashivb
requested changes
Aug 29, 2020
Member
inashivb
left a comment
inashivb
left a comment
There was a problem hiding this comment.
Hi @michaelschem !
Thanks for your contribution!
Could you please clean the commit history, write a descriptive commit message about what your PR does and re-submit? We'll be happy to take a look a look at it.
Contributor
Author
|
Absolutely. I'll get it cleaned up soon and resubmit. |
michaelschem
force-pushed
the
iprep_compatibility
branch
from
ef8db10 to
bdd94ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request
-- thank you.
https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
contribution agreement at
https://suricata-ids.org/about/contribution-agreement/
changes made (if applicable)
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3721
Describe changes: