mqtt: resubscribe inbox topic on reconnect#169
Merged
rcschrg merged 2 commits intodevelopmentfrom Apr 17, 2025
Merged
Conversation
unify call to _send_external_message by making it asnyc as the other containers do catch RuntimeError when send_external_message fails - this does not resubmit the message to the broker yet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #169 +/- ##
===============================================
- Coverage 89.15% 88.99% -0.16%
===============================================
Files 22 22
Lines 2507 2516 +9
===============================================
+ Hits 2235 2239 +4
- Misses 272 277 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aa066fb to
af8228f
Compare
Collaborator
Author
|
Lost messages and not sending again could be handled in the For now, I'd like to add this change as is, as it fixes the access to an unitialized |
rcschrg
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unify call to
_send_external_messageby making it async as the other containerscatch
RuntimeErrorwhensend_external_messagefails - this does not resubmit the message to the broker yetrelated to #97
This does not yet fix all issues when the broker goes down, as messages are lost and not sent again.
Would be good to handle this in the agent framework and not in the simulation itself.