Skip to content

Fix padding#199

Merged
albangossard merged 7 commits into
devfrom
fixPadding
Jun 4, 2026
Merged

Fix padding#199
albangossard merged 7 commits into
devfrom
fixPadding

Conversation

@albangossard

@albangossard albangossard commented May 27, 2026

Copy link
Copy Markdown
Member
  • Fix padding
  • Add asserts when the provided measurements fall outside of the climate data time window
  • Add stakes measurements on the profile plot

@albangossard albangossard added the bug Something isn't working label May 27, 2026
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.00000% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.79%. Comparing base (679647e) to head (8669bc3).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
massbalancemachine/plots/profile_plots.py 0.00% 10 Missing ⚠️
...lancemachine/models/TorchNeuralNetworkRegressor.py 0.00% 6 Missing ⚠️
tests/utils/test_dates.py 96.33% 4 Missing ⚠️
massbalancemachine/data_preprocessing/wgms.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
+ Coverage   37.81%   38.79%   +0.97%     
==========================================
  Files          79       80       +1     
  Lines        6624     6754     +130     
==========================================
+ Hits         2505     2620     +115     
- Misses       4119     4134      +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- add more glacier names
- add option to create maps of specific test glaciers only
@albangossard

Copy link
Copy Markdown
Member Author

Since I spotted another bug that affects the construction of the time window, I'm turning this PR into draft the time I find the root cause of this second issue.

@albangossard albangossard marked this pull request as draft June 2, 2026 08:44
@marvande marvande marked this pull request as ready for review June 4, 2026 08:42
@albangossard albangossard merged commit 256dbed into dev Jun 4, 2026
7 of 8 checks passed
@albangossard albangossard deleted the fixPadding branch June 4, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants