[19.0][MIG] field_vector: Migration to 19.0 #3430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
fyi @lmignon |
lmignon
requested changes
Oct 27, 2025
Contributor
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
Thank you for the migration @hailangvn
Some comments about your changes...
hailangvn
force-pushed
the
19.0-mig-field_vector
branch
from
a86f032 to
d3fbba1
Compare
pg_typeof on a vector returns the vector’s base type, not its size; to know length you must query array_length or cardinality for vectors using the pgvector extension (e.g., select vector_dims(v)).
hailangvn
force-pushed
the
19.0-mig-field_vector
branch
from
d3fbba1 to
2015554
Compare
lmignon
approved these changes
Oct 29, 2025
Contributor
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
Thank you @hailangvn for the migration. LGTM (Code review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to migrate field_vector module to 19.0.