-
-
Notifications
You must be signed in to change notification settings - Fork 585
18.0 add contract line defer #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
6f7b2ba to
c710c94
Compare
acsonefho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor stuff!
Really good job 💪
| "data": [ | ||
| "views/contract_line.xml", | ||
| ], | ||
| "auto_install": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense for OCA module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense for a bridge module. If both contract_line_defer and contract_line_successor are installed, this module should be installed to make sure everything works properly.
From Odoo docs:
auto_install (bool or list(str), default: False)
If True, this module will automatically be installed if all of its dependencies are installed.It is generally used for “link modules” implementing synergetic integration between two otherwise independent modules.
product_contract_line_defer/models/sale_order_line_contract_mixin.py
Outdated
Show resolved
Hide resolved
c710c94 to
0541b4c
Compare
0541b4c to
00ca05a
Compare
Defer Contract Lines to avoid invoicing while start date unknown
Enable to defer contract line's invoicing. If a contract line start date is not known, it can be deferred. It will not be invoiced until manually activated.