[14.0][MIG] - migration pricelist brand to 14.0#122
Open
[14.0][MIG] - migration pricelist brand to 14.0#122
Conversation
Author
|
Hi, I need guidance to know how to solve the test errors that are appearing in the PR |
sbejaoui
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sbejaoui
added
no stale
FrancescoBallerini
approved these changes
Apr 9, 2024
| AND (item.product_brand_id IS NULL OR item.product_brand_id = any(%s)) | ||
| AND (item.pricelist_id = %s) | ||
| AND (item.date_start IS NULL OR item.date_start<=%s) | ||
| AND (item.date_end IS NULL OR item.date_end>=%s) |
There was a problem hiding this comment.
Hi, I think a line
AND (item.active = TRUE)
is missing if compared to the original method. Has it been removed for specific reasons?
https://github.com/odoo/odoo/blob/14.0/addons/product/models/product_pricelist.py#L111
Contributor
|
Can you squash the new test commit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.