fix(tizen): restore avplay video rendering and fix playback issues#59
fix(tizen): restore avplay video rendering and fix playback issues#59anudeepreddy wants to merge 1 commit into
Conversation
|
/oc Review this pull request: check for code quality issues, look for potential bugs and suggest improvements |
|
Findings:
Overall, the AVPlay rendering fix looks directionally correct, but I’d address the stall-guard regression before merging. |
|
hey @anudeepreddy, could you please take a look at this and fix any potential issues mentioned so we can merge? |
|
The ticktimer was not removed in the previous commit and is removed now in the latest commit and also made sure that timeupdate event is preserved. The console.log still exists, I hope that is fine |
|
Hey, sorry, I didn't have the time to properly review this pull request before. Could you resolve merge issues and I will take a look at it again? |
|
updated, but there is a gap with this implementation. Since we are not using object instead of a video element the subtitles no longer work when using avplay. We need a unified way to support subtitles across both implementations |
I think @WhiteGiso has been working on this, you can contact him since he has been working more on this specifically than me |
|
Excuse me so much @anudeepreddy, can you explain me better after updating to the latest version of the main? Thank you very much. |

The tizen player was not configured properly, the initial assumption was tizen avplay was unable to play content but after a bit of testing it turns out it's used a bit differently which was causing the video playback to be missing and was just playing audio. This PR fixes that problem.