escape commas/backslashes in http-header-fields for mpv (macOS + windows)#144
Merged
Merged
Conversation
… Windows) mpv parses http-header-fields as a comma-separated list. Headers containing commas in values (e.g. auth tokens, cookies) were being split incorrectly, breaking authenticated streams (Real-Debrid, etc.). Escape \ and , in each header line before joining, matching the fix already applied in NuvioTV and NuvioMobile.
skoruppa
changed the title
skoruppa
changed the title
aelrased
pushed a commit
to aelrased/NuvioDesktop
that referenced
this pull request
Jun 29, 2026
…caping escape commas/backslashes in http-header-fields for mpv (macOS + windows)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
Why
mpv parses
http-header-fieldsas a comma-separated list. Headers containing commas in values (auth tokens, cookies) are split incorrectly, causing broken authenticated streams that fail to load or return 403.Desktop scope
macOS (
player_bridge.mm) and Windows (player_bridge.cpp). Both join header lines with,but don't escape commas or backslashes in header values.Issue or approval
Same fix already applied in NuvioTV (commit
108bb6fe) and NuvioMobile (MPVPlayerBridge.swift). This aligns the desktop native bridges.UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Testing
Screenshots / Video
Not a UI change.
Breaking changes
None.
Linked issues
Same root cause as NuvioTV fix (commit
108bb6fe7). No standalone issue - discovered during Linux player implementation #142