[Feature] Added a info button to show stream infomation#111
Open
anilabhadatta wants to merge 8 commits into
Open
[Feature] Added a info button to show stream infomation#111anilabhadatta wants to merge 8 commits into
anilabhadatta wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a comprehensive, real-time diagnostic stream information panel to the Nuvio Desktop media player, using a dynamic JSON telemetry payload.
PR type
Why
1. Unified Telemetry Bridge & Stream Diagnostics Panel:
mediaInfoJsonbridge across both Windows (player_bridge.cpp) and macOS (player_bridge.mm). This payloads real-time diagnostic data includingvideoCodec,videoDecoder,hwdecCurrent,audioCodec, andbitratesdirectly to thecontrols.jsWebView.2. Intelligent Media Labelling & False Positive Fixes:
libmpvoccasionally returned placeholder text ("none","unknown","0","false") for thedv_profileproperty instead of an empty string. The C++ and JS layers now rigorously filter out these placeholders.3. UX Refinements:
Desktop scope
This PR modifies the desktop native player bridges, player UI logic, and shared player states. Mobile codebase is unaffected.
player_bridge.cpp(Windows) andplayer_bridge.mm(macOS) to output JSON telemetry.NativePlayerController.ktand KMP Player models to remove legacyHdrPlaybackFormatandvideoHdrFormatreferences.controls.jsandcontrols.htmlto consume JSON telemetry, render the diagnostic panel, and implement the auto-hide functionality.Issue or approval
Feature Request: Stream Telemetry / Diagnostics Overlay Refactor.
#41 : People are unable to know if the current stream is playing through Dolby Vision HDR format
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
None.
Testing
Manually verified:
Screenshots / Video
Breaking changes
None.
Linked issues
Feature Request: Stream Telemetry / Diagnostics Overlay Refactor.
#41 : People are unable to know if the current stream is playing through Dolby Vision HDR format
Note:
The previous pull request closed due to branch rename:
#86