Fix desktop addon request failures after repeated fetches#104
Open
amackarrey wants to merge 1 commit into
Open
Fix desktop addon request failures after repeated fetches#104amackarrey wants to merge 1 commit into
amackarrey wants to merge 1 commit into
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes repeated desktop addon request failures where metadata and stream fetching can start failing with:
java.io.IOException: Can't assign requested addressThe fix reuses desktop HTTP clients, limits concurrent addon HTTP requests, and retries transient socket-level failures.
PR type
Why
After repeated metadata and stream fetches, desktop addon requests can fail with
Can't assign requested address. When this happens, addons such as AIOStreams and AIOMetadata may return no streams or stop loading metadata until the app is restarted.The old desktop implementation also created a new no-redirect
HttpClientfor requests that disabled redirects. This PR keeps the fix focused on desktop addon request reliability.Desktop scope
Desktop shared addon networking code is affected.
This was reported on macOS, but the changed code is in the desktop source set and applies to desktop addon HTTP requests generally.
Issue or approval
Fixes #78
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
This PR only changes desktop addon HTTP request handling.
It does not change UI, stream ranking, addon parsing, metadata parsing, playback behavior, release versioning, dependencies, or packaging configuration.
Testing
Tested on macOS.
Commands run:
Result: passed.
Screenshots / Video
Not a UI change.
Breaking changes
None.
Linked issues
Fixes #78