Skip to content

Pnp plurals #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plural wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pnp plurals #1007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
895892d
Update card type pluralization on the PNP page.
plural May 20, 2026
fa57d87
Make pluralization agree with number of cards.
plural May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions web/js/pnp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ var imported_cards = {};
else return o1.type.code > o2.type.code? 1 : -1;
});
}

imported_cards.clear_all = function() {
imported_cards.entries = [];
imported_cards.errors = [];
Expand Down Expand Up @@ -346,7 +346,7 @@ function build_one_line(imported_entry) {
elem.append(`<input class="pnp-data" type="hidden" name="${index}" value="${card.code}:${qty_int}">`);
elem.append(`<input type="number" class="form-control pnp-number-input" placeholder="${qty_int}">`);
elem.append(' x ');
var a = $(`<a class="card" data-code="${card.code}" href="javascript:void(0)">` +
var a = $(`<a class="card" data-code="${card.code}" href="javascript:void(0)">` +
`${strikethrough? '<s>' : ''}${card.title}${strikethrough? '</s>' : ''} </a>`);
if(!imported_entry.enabled) {
a[0].classList.add("text-muted");
Expand Down Expand Up @@ -480,8 +480,11 @@ function update_stats() {
var html = '';
$.each(types, function (key, value) {
size+=value;
key = key == "Identity"? "Identities" : key + 's';
html += value+' '+key+'<br>';
let cardType = key;
if (!['Identity', 'Ice'].includes(cardType) && value > 1) {
cardType = cardType + 's';
}
html += value + ' ' + cardType + '<br />';
});
html = '<hr style="width:7em;margin-left:0;">' + html;
if(imported_cards.get_disabled().length) {
Expand Down