Conversation
| const { onGuestHomePage } = useHomePageContext(); | ||
| const [allTeams, setAllTeams] = useState<LinkItem[]>([]); | ||
|
|
||
| getAllTeams().then((response) => { |
There was a problem hiding this comment.
We should be displaying all team types, so instead using useAllTeamTypes instead, make sure you are using the one from teams.hooks.ts
| setAllTeams( | ||
| response.data.map((team) => ({ | ||
| name: team.teamName, | ||
| icon: undefined, |
There was a problem hiding this comment.
Each team type should have an icon associated with it, can you display those here?
| const { onGuestHomePage } = useHomePageContext(); | ||
| const [allTeams, setAllTeams] = useState<LinkItem[]>([]); | ||
|
|
||
| const getIcon = (iconName: string) => { |
There was a problem hiding this comment.
Each team type has an icon associated with it, can you display those instead of hard coding the icon for each team type?
| }; | ||
|
|
||
| useEffect(() => { | ||
| getAllTeamTypes() |
There was a problem hiding this comment.
Instead of directly calling the API here for getting all team types, can you use the hook (useAllTeamTypes from team-types.hooks.ts), since it has the error handling/loading built into it?
chpy04
left a comment
chpy04
left a comment
There was a problem hiding this comment.
Everything looks fine except why are we removing the images from the old homepage? That entire page should get removed when we are ready to swap it out
3 participants
Changes
Added a sidebar to the /home/guest route. Sidebar only shows project and team related pages, along with sponsors and info.
Notes
The design review and sponsors page currently don't lead to anywhere. Also the two images on the /home/guest page aren't working so I just removed them entirely.
Screenshots
yarn.lockchanges (unless dependencies have changed)Closes #3872