Skip to content

Comments

fixed build system not returning docker command#368

Merged
aolgeirson merged 5 commits intomainfrom
364-system-error-codes
Feb 22, 2026
Merged

fixed build system not returning docker command#368
aolgeirson merged 5 commits intomainfrom
364-system-error-codes

Conversation

@aolgeirson
Copy link
Contributor

@aolgeirson aolgeirson commented Feb 9, 2026

Changes

ner build and ner test now return the exit code of the docker command as opposed to just 0

Notes

The rationale for this change was to allow command chaning such as ner build && ner flash

Test Cases

  • ner build on a functional Cerberus-2.0 returns 0
  • ner build on a broken Cerberus-2.0 returns the error code of the compiler

To Do

This is a minor change that shouldn't require continuing effort

Checklist

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #364

Copilot AI review requested due to automatic review settings February 9, 2026 00:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ner build wrapper so failures inside Docker propagate back to the user’s shell, enabling reliable command chaining (e.g., ner build && ner flash) and addressing Issue #364.

Changes:

  • Capture docker compose run exit codes during ner build and exit non-zero on failure.
  • Refactor run_command() / run_command_docker() to return command return codes (intended behavior).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dnakhooda dnakhooda self-requested a review February 10, 2026 01:27
Copy link
Member

@dnakhooda dnakhooda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm...

@aolgeirson aolgeirson merged commit a778338 into main Feb 22, 2026
2 checks passed
@aolgeirson aolgeirson deleted the 364-system-error-codes branch February 22, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ner build doesn't pass return code via bash

2 participants