fixed build system not returning docker command#368
Merged
aolgeirson merged 5 commits intomainfrom Feb 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the ner build wrapper so failures inside Docker propagate back to the user’s shell, enabling reliable command chaining (e.g., ner build && ner flash) and addressing Issue #364.
Changes:
- Capture
docker compose runexit codes duringner buildand exit non-zero on failure. - Refactor
run_command()/run_command_docker()to return command return codes (intended behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ner buildandner testnow return the exit code of the docker command as opposed to just0Notes
The rationale for this change was to allow command chaning such as
ner build && ner flashTest Cases
ner buildon a functional Cerberus-2.0 returns 0ner buildon a broken Cerberus-2.0 returns the error code of the compilerTo Do
This is a minor change that shouldn't require continuing effort
Checklist
Closes #364