Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new API endpoint and functionality to migrate submission outputs from GridFS to Minio storage. The migration includes data consistency validation before removing files from GridFS.
- Adds
migrate_output_to_minio()method to handle submission output migration from GridFS to Minio - Creates new API endpoint
/submission/<id>/migrate-outputwith proper authentication and authorization - Updates the Go migration script to call both code and output migration endpoints
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mongo/submission.py | Adds output migration methods with consistency checking and Minio path generation updates |
| model/submission.py | Creates new API endpoint for output migration with permission validation |
| migrate.go | Adds output migration function call and simplifies code by removing unused imports and functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aokblast
reviewed
Sep 22, 2025
| """ | ||
| for (i, task) in enumerate(self.tasks): | ||
| for (j, case) in enumerate(task.cases): | ||
| self._migrate_case_output_to_minio(case, i, j) |
Contributor
There was a problem hiding this comment.
Why j is necessery in the case you pass "case" to callee?
Member
Author
There was a problem hiding this comment.
Because I need i and j to generate path for minio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update #298