Skip to content

Add frame limiter FPS offset#256

Open
kristofferR wants to merge 2 commits into
Nonary:masterfrom
kristofferR:codex/frame-limiter-fps-offset
Open

Add frame limiter FPS offset#256
kristofferR wants to merge 2 commits into
Nonary:masterfrom
kristofferR:codex/frame-limiter-fps-offset

Conversation

@kristofferR

@kristofferR kristofferR commented May 26, 2026

Copy link
Copy Markdown

I've implemented the RTSS frame limiter offset requested in #177 :)

Sorry for pushing this here a little prematurely, Codex did it when I asked to "push the pr to my fork".

Summary

  • Add frame_limiter_fps_offset so the automatic frame limiter can subtract FPS from the client-requested stream rate.
  • Apply the offset to RTSS and NVIDIA limiter paths while keeping manual frame_limiter_fps_limit authoritative.
  • Surface the setting in the Frame Limiter UI, per-app overrides, docs, and English locale files.

Validation

  • git diff --check
  • jq empty src_assets/common/assets/web/public/assets/locale/*.json
  • bun run build

Ref #177

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

return rtss_streaming_start(fps, 1);

P1 Badge Replace stale fps variable in RTSS refresh fallback

After changing rtss_streaming_refresh to accept (scaled_limit, denominator), this fallback still calls rtss_streaming_start(fps, 1), but fps is no longer defined in scope. On Windows builds, this causes a compile error in rtss_integration.cpp, blocking the build before runtime. The fallback should pass the new argument (likely scaled_limit) instead of the removed identifier.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kristofferR kristofferR reopened this May 26, 2026

Copy link
Copy Markdown
Author

Validation update after pushing f19edf3f:

  • Reopened this PR and confirmed the head is now f19edf3f00159d9a4f448a057e1ffbdf30a4749b.
  • Configured build-dev with MSYS2 UCRT64, Debug, BUILD_TESTS=ON, SUNSHINE_ENABLE_WEBRTC=OFF, CUDA_FAIL_ON_MISSING=OFF.
  • ninja -C build-dev completed successfully, including sunshine.exe, helper tools, tests/test_sunshine.exe, and the debug Web UI bundle.
  • Launched the built sunshine.exe; the configuration UI served successfully at https://localhost:47990.
  • ctest --test-dir build-dev --output-on-failure reported no registered CTest tests.
  • Direct build-dev/tests/test_sunshine.exe --gtest_brief=1 currently fails existing Playnite sync/autosync, locale/config consistency, and mDNS naming expectations unrelated to the frame limiter build/run path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant