Add frame limiter FPS offset#256
Open
kristofferR wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
fps variable in RTSS refresh fallback
After changing rtss_streaming_refresh to accept (scaled_limit, denominator), this fallback still calls rtss_streaming_start(fps, 1), but fps is no longer defined in scope. On Windows builds, this causes a compile error in rtss_integration.cpp, blocking the build before runtime. The fallback should pass the new argument (likely scaled_limit) instead of the removed identifier.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Author
|
Validation update after pushing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented the RTSS frame limiter offset requested in #177 :)
Sorry for pushing this here a little prematurely, Codex did it when I asked to "push the pr to my fork".
Summary
frame_limiter_fps_offsetso the automatic frame limiter can subtract FPS from the client-requested stream rate.frame_limiter_fps_limitauthoritative.Validation
git diff --checkjq empty src_assets/common/assets/web/public/assets/locale/*.jsonbun run buildRef #177