MNEMONIC-109:Create a testcase to manage durable object on volatile m…#22
Open
lcy0816 wants to merge 3 commits intoNonVolatileComputing:masterfrom
lcy0816:master
Open
MNEMONIC-109:Create a testcase to manage durable object on volatile m…#22lcy0816 wants to merge 3 commits intoNonVolatileComputing:masterfrom lcy0816:master
lcy0816 wants to merge 3 commits intoNonVolatileComputing:masterfrom
lcy0816:master
Conversation
AI-Memory
reviewed
Sep 28, 2016
| */ | ||
| public class VolatileMemAllocator extends RestorableAllocator<VolatileMemAllocator> { | ||
| public class VolatileMemAllocator extends RestorableAllocator<VolatileMemAllocator> | ||
| implements AddressTranslator { |
Member
There was a problem hiding this comment.
Please remove this change because it parent class already implemented the interface of AddressTranslator.
AI-Memory
reviewed
Sep 28, 2016
| public void testGenPeople() throws OutOfHybridMemory, RetrieveDurableEntityError { | ||
| Random rand = Utils.createRandom(); | ||
| VolatileMemAllocator act = new VolatileMemAllocator(Utils.getVolatileMemoryAllocatorService("vmem"), | ||
| 1024 * 1024 * 8, "./pobj_person.dat", true); |
Member
There was a problem hiding this comment.
Please use "." instead of "./pobj_person.dat" because this parameter is native library specific.
AI-Memory
reviewed
Sep 28, 2016
| }); | ||
|
|
||
| for (long i = 0; i < cKEYCAPACITY; ++i) { | ||
| act.setHandler(i, 0L); |
Member
There was a problem hiding this comment.
There is no handler store for Volatile memory service so you cannot use setHandler()/getHandler()
AI-Memory
reviewed
Sep 28, 2016
| } | ||
|
|
||
| @Test(dependsOnMethods = { "testGenPeople" }) | ||
| public void testCheckPeople() throws RetrieveDurableEntityError { |
Member
There was a problem hiding this comment.
Please remove this testcase because volatile memory service does not support any persistence feature.
Member
There was a problem hiding this comment.
Please create a new testcase to verify the data that has already been installed by the first testcase.
AI-Memory
force-pushed
the
master
branch
18 times, most recently
from
9373f5e to
472072e
Compare
AI-Memory
force-pushed
the
master
branch
2 times, most recently
from
263dd0e to
83cac44
Compare
AI-Memory
force-pushed
the
master
branch
3 times, most recently
from
7fd302b to
d788376
Compare
AI-Memory
force-pushed
the
master
branch
17 times, most recently
from
a211966 to
0f2476d
Compare
AI-Memory
force-pushed
the
master
branch
3 times, most recently
from
0aef031 to
3f4eb81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…emory service