Added timsTOF support #555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for timsTOF by allowing model runner to take in a .d directory
…ixed directory discovery Changes made - Fixed the linting - Added test for new functionality - Changed file_formats.md to add .d folder type - Added changes to CHANGELOG.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #555 +/- ##
==========================================
+ Coverage 94.28% 94.62% +0.33%
==========================================
Files 14 14
Lines 1487 1487
==========================================
+ Hits 1402 1407 +5
+ Misses 85 80 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bittremieux
requested changes
Nov 27, 2025
Fixed file logic
bhavyak7-lab
commented
Dec 2, 2025
bittremieux
requested changes
Dec 11, 2025
bittremieux
approved these changes
Dec 17, 2025
Collaborator
|
This looks good, thanks @bhavyak7-lab. We'll wait a bit longer to merge it into dev because there needs to be a new release of DepthCharge first, which we'll need to specify in the dependencies then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made