libcupsfilters: custom test page#526255
Open
raboof wants to merge 1 commit into
Open
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
The upstream CUPS test page is terrible: it includes images that are way lower-quality than today's consumer printers, both in terms of resolution and colour depth. Upstream [doesn't seem interested](OpenPrinting/libcupsfilters#100) in improving this. The next best thing is to at least have a slightly-better test page in Nix, and take the opportunity to throw in a Nix logo or two. I spoke to someone who is familiar with print and they mentioned solid rgbcmyk blocks are more useful than the 'color wheel'. I could imagine further improvements (maybe adding a 'rainbow gradient', text in various point sizes, 'hyperbolic wedges'), but this seems like a good first step.
raboof
force-pushed
the
libcupsfilters-custom-testpage
branch
from
7024158 to
b869059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream CUPS test page is terrible: it includes images that are way lower-quality than today's consumer printers, both in terms of resolution and colour depth.
Upstream doesn't seem interested in improving this. The next best thing is to at least have a slightly-better test page in Nix, and take the opportunity to throw in a Nix logo or two.
I spoke to someone who is familiar with print and they mentioned solid rgbcmyk blocks are more useful than the 'color wheel'.
I could imagine further improvements (maybe adding a 'rainbow gradient', text in various point sizes, 'hyperbolic wedges'), but this seems like a good first step.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.