kallisto: fix build with gcc 15

[MiniHarinn]

Vendor the patch from pmelsted/bifrost#18
ZHF: #516381 (Part of)

Hydra Failure (Click the banner to go to Hydra build report):

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
• Follows the automation/AI policy.

[MiniHarinn]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 522275
Commit: 6f380a6d96f437fa07687ca50ac9aa7ec294dd2a (subsequent changes)
Merge: 35f64fd02d9875a4691f3d12be4a21de16c0ef0b

Logs: https://github.com/MiniHarinn/nixpkgs-review-gha/actions/runs/26172139056

---

x86_64-linux

✅ 1 package built:

• kallisto

---

aarch64-linux

✅ 1 package built:

• kallisto

---

x86_64-darwin

✅ No rebuilds

---

aarch64-darwin

✅ No rebuilds

[arcadio]

Thanks for your patch. I would prefer to point to upstream instead of a third party (FreeBSD). This seems to work on current unstable:

# Fix typo in vendored bifrost DataStorage<U> copy constructor exposed by gcc 15.
# https://github.com/pmelsted/bifrost/pull/18
patches = [(fetchpatch2 {
    name = "bifrost-fix-datastorage-sz_link-typo.patch";
    url = "https://github.com/pmelsted/bifrost/pull/18.patch";
    hash = "sha256-FX9VKEkzfPAEmYWoMs189qSL4rM6/pCF4QR82zp/eWU=";
    stripLen = 1;
    extraPrefix = "ext/bifrost/";
})];

[MiniHarinn]

That would be nice if it were merged upstream (but it's still open). Per the documentation, the URL of the PR plus .patch is unstable url (it can change in case of a force-push, etc.), so I opted for using FreeBSD's patch instead. If you still want to point to upstream, I can vendor that .patch and use it instead. Sounds good?

[arcadio]

Sure, committing the patch is the best option. The pull request URL would also work well as a stopgap. Hash mismatches would warn us about any pull request changes. It's simpler but a bit less reproducible. I'll discuss merging it upstream, but this will take time.

[arcadio]

Approved, many thanks for your PR.