Skip to content

python3Packages.srctools: fix build failure due to meson-python & pythoncapi-compat#493800

Merged
isabelroses merged 1 commit intoNixOS:masterfrom
different-name:srctools-build-failure
Feb 25, 2026
Merged

python3Packages.srctools: fix build failure due to meson-python & pythoncapi-compat#493800
isabelroses merged 1 commit intoNixOS:masterfrom
different-name:srctools-build-failure

Conversation

@different-name
Copy link
Copy Markdown
Contributor

@different-name different-name commented Feb 24, 2026

Fixes: #493634

Build failure caused by two issues:

  1. meson-python was updated 0.18.0 -> 0.19.0, while srctools requires meson-python == 0.18.0
  2. For some reason, pythoncapi-compat tests are failing - see Add support for pytest python/pythoncapi-compat#169

Relaxed deps for meson-python to >= 0.18.0
Patched pythoncapi-compat to fix test import error

Patch can be removed once PR for pythoncapi-compat is merged, and a new srctools release is made with a fixed version of pythoncapi-compat

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 24, 2026
Ambossmann
Ambossmann approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ambossmann Ambossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and everything builds.

nixpkgs-review result for #493800

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 493800
Commit: 27668c34c63b19578a3503200a09248c1547541e (subsequent changes)
Merge: 4e1cac68b8ff700e8aec9e6c3a12237a18e9eb37

Logs: https://github.com/Ambossmann/nixpkgs-review-gha/actions/runs/22374324807

x86_64-linux

✅ 4 packages built:
  • python313Packages.srctools
  • python313Packages.srctools.dist
  • python314Packages.srctools
  • python314Packages.srctools.dist

aarch64-linux

✅ 4 packages built:
  • python313Packages.srctools
  • python313Packages.srctools.dist
  • python314Packages.srctools
  • python314Packages.srctools.dist

x86_64-darwin (sandbox = relaxed)

✅ 4 packages built:
  • python313Packages.srctools
  • python313Packages.srctools.dist
  • python314Packages.srctools
  • python314Packages.srctools.dist

aarch64-darwin (sandbox = relaxed)

✅ 4 packages built:
  • python313Packages.srctools
  • python313Packages.srctools.dist
  • python314Packages.srctools
  • python314Packages.srctools.dist

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 24, 2026
@isabelroses isabelroses added this pull request to the merge queue Feb 25, 2026
Merged via the queue into NixOS:master with commit 52c484e Feb 25, 2026
35 of 37 checks passed
@different-name different-name deleted the srctools-build-failure branch February 25, 2026 01:21
@different-name different-name mentioned this pull request Mar 4, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ambossmann Ambossmann Ambossmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: python3Packages.srctools

3 participants

@different-name @Ambossmann @isabelroses