deepfilternet: 0.5.6 -> 0.5.6-unstable-2024-08-15, fix build#334835
Closed
Philipp-M wants to merge 1 commit into
Closed
deepfilternet: 0.5.6 -> 0.5.6-unstable-2024-08-15, fix build#334835Philipp-M wants to merge 1 commit into
Philipp-M wants to merge 1 commit into
Conversation
ofborg
Bot
added
10.rebuild-darwin: 1-10
7 tasks
Member
|
#334838 had a simpler approach — would it work? cc @Mrmaxmeier |
Member
Author
|
Sure, I'm indifferent with either solution (as long as it doesn't break :)) |
| }; | ||
|
|
||
| postPatch = '' | ||
| ln --force -s ${./Cargo.lock} Cargo.lock |
Member
There was a problem hiding this comment.
Suggested change
| ln --force -s ${./Cargo.lock} Cargo.lock | |
| ln -fs ${./Cargo.lock} Cargo.lock |
Member
What other issues? |
Member
|
Closing in favor of #334838 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See #332957 for more details, this updates it to the current git version and the local Cargo.lock and patches it, because otherwise the build still breaks (because of other issues).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.