Skip to content

Conversation

@olegrok
Copy link
Contributor

@olegrok olegrok commented Jun 30, 2025

This patch updates dependencies in general but the main change is updating badgerdb to this branch: https://github.com/NilFoundation/badger/tree/nil

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Go toolchain in Nix and bumps a wide range of module dependencies, with the primary goal of replacing the upstream BadgerDB v4 dependency with the NilFoundation fork.

  • Switch Nix from buildGo124Module to buildGoLatestModule and update the vendored hash.
  • Remove the override for gopls in Nix.
  • Bump Go directive and toolchain in go.mod and update many dependency versions, including a replace for badger/v4 to the NilFoundation branch.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
nix/nil.nix Switched from buildGo124Module to buildGoLatestModule, updated vendorHash, and adjusted the gopls override.
go.mod Changed go directive and added toolchain, replaced BadgerDB import, and bumped numerous module versions.
Comments suppressed due to low confidence (2)

nix/nil.nix:81

  • [nitpick] The gopls package is no longer wrapped with overrideBuildGoModule, which the other Go tools use to enforce the buildGoLatestModule builder. Consider reapplying overrideBuildGoModule to gopls to maintain a consistent Go version and build flags.
    gopls

go.mod:3

  • The go directive typically specifies only major and minor versions (e.g., go 1.24). Using a patch version like 1.24.0 is unconventional and may not be recognized; consider reverting this to go 1.24.
go 1.24.0

@dmtrskv
Copy link
Contributor

dmtrskv commented Jun 30, 2025

Why did biome files change?

@olegrok
Copy link
Contributor Author

olegrok commented Jun 30, 2025

Why did biome files change?

New major version of biome is delivered with new nixpkgs version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants