-
Notifications
You must be signed in to change notification settings - Fork 43
Update badger db #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update badger db #986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Go toolchain in Nix and bumps a wide range of module dependencies, with the primary goal of replacing the upstream BadgerDB v4 dependency with the NilFoundation fork.
- Switch Nix from
buildGo124ModuletobuildGoLatestModuleand update the vendored hash. - Remove the override for
goplsin Nix. - Bump Go directive and toolchain in
go.modand update many dependency versions, including areplaceforbadger/v4to the NilFoundation branch.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nix/nil.nix | Switched from buildGo124Module to buildGoLatestModule, updated vendorHash, and adjusted the gopls override. |
| go.mod | Changed go directive and added toolchain, replaced BadgerDB import, and bumped numerous module versions. |
Comments suppressed due to low confidence (2)
nix/nil.nix:81
- [nitpick] The
goplspackage is no longer wrapped withoverrideBuildGoModule, which the other Go tools use to enforce thebuildGoLatestModulebuilder. Consider reapplyingoverrideBuildGoModuletogoplsto maintain a consistent Go version and build flags.
gopls
go.mod:3
- The
godirective typically specifies only major and minor versions (e.g.,go 1.24). Using a patch version like1.24.0is unconventional and may not be recognized; consider reverting this togo 1.24.
go 1.24.0
|
Why did biome files change? |
New major version of biome is delivered with new nixpkgs version |
Just regular update.
This patch updates dependencies in general but the main change is updating badgerdb to this branch: https://github.com/NilFoundation/badger/tree/nil