Feat/hook test#422
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
admin 영역의 훅 테스트 커버리지를 보강하고, 훅 소비 컴포넌트(ShareBanner) 통합 테스트를 추가했습니다.
회귀 위험이 높은 타이머/브라우저 이벤트/스토리지/DOM side-effect 중심으로 검증 범위를 확장했습니다.
변경 사항
1) Hook Unit Test 추가
apps/admin/src/hooks/useShareBannerVisibility.test.tsapps/admin/src/hooks/usePopupDialog.test.tsxapps/admin/src/hooks/useDeviceWidth.test.tsapps/admin/src/hooks/useClipboardCopy.test.tsapps/admin/src/hooks/useBodyScrollLock.test.tsapps/admin/src/hooks/useIsMobile.test.tsapps/admin/src/hooks/useScrollDirection.test.tsapps/admin/src/hooks/useCookie.test.ts핵심 검증 포인트:
2) Hook 소비 통합 테스트 추가
apps/admin/src/components/ShareBanner/ShareBanner.integration.test.tsx핵심 검증 포인트:
isVisible에 따른 렌더링 분기dismissForToday호출navigator.share호출검증
yarn workspace admin test참고
develop대비 아래 파일만 추가되었습니다.apps/admin/src/components/ShareBanner/ShareBanner.integration.test.tsxapps/admin/src/hooks/useBodyScrollLock.test.tsapps/admin/src/hooks/useClipboardCopy.test.tsapps/admin/src/hooks/useCookie.test.tsapps/admin/src/hooks/useDeviceWidth.test.tsapps/admin/src/hooks/useIsMobile.test.tsapps/admin/src/hooks/usePopupDialog.test.tsxapps/admin/src/hooks/useScrollDirection.test.tsapps/admin/src/hooks/useShareBannerVisibility.test.ts