Adds DLQ tag to created queues#69
Open
corydolphin wants to merge 3 commits intoNextdoor:masterfrom
Open
Conversation
corydolphin
commented
Jul 12, 2021
|
|
||
| logger.info('Creating new SQS queue: %s' % queue_name) | ||
| queue = self._client.create_queue(QueueName=queue_name) | ||
| queue = self._client.create_queue(QueueName=queue_name, tags={"dlq":str(is_dlq)}) |
Collaborator
Author
There was a problem hiding this comment.
Tags looks to be lower case in the Boto3 docs, however inconsistent. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sqs.html#SQS.Client.create_queue
leighpauls
approved these changes
Jul 12, 2021
Update version.py
stlava
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.