Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s release/version metadata, refreshes build tool dependencies (Astro/TypeScript and transitive lockfile updates), and expands the framework config documentation across JA/EN/CN.
Changes:
- Bump package version to
2.0.4and updateastroandtypescriptdevDependencies. - Regenerate
package-lock.jsonto reflect updated dependency graph. - Improve framework config docs content/structure across Japanese/English/Chinese pages.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump and devDependency updates (Astro/TypeScript) |
| package-lock.json | Lockfile refresh reflecting new dependency graph and engine constraints |
| docs/ja/reference/framework/config/index.html | Expanded/clarified config documentation (JA) |
| docs/en/reference/framework/config/index.html | Expanded/clarified config documentation (EN) |
| docs/cn/reference/framework/config/index.html | Expanded/clarified config documentation (CN) |
Comments suppressed due to low confidence (1)
package.json:22
- The lockfile indicates
astro@6.1.6requires Node>=22.12.0(see itsenginesfield). Sincepackage.jsondoesn’t declare anengines.node, consumers may only find out at install/runtime. Please either (1) add an explicitenginesentry (and align CI/docs), or (2) pin Astro to a version compatible with the project’s supported Node range.
"scripts": {
"start": "astro dev",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
},
"devDependencies": {
"typescript": "^6.0.2",
"@astrojs/sitemap": "^3.7.2",
"aos": "^2.3.4",
"astro": "^6.1.6",
"bootstrap": "^5.3.8",
"bootstrap-icons": "^1.13.1",
"unist-util-visit": "^5.1.0"
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <blockquote> | ||
| <p>[!WARNING] | ||
| The only valid properties in <code>stage.json</code> are <code>width</code>, <code>height</code>, <code>fps</code>, and <code>options</code>. | ||
| Properties such as <code>align</code> and <code>scaleMode</code> — even though they relate to Stage display — do not exist in <code>stage.json</code>. | ||
| If you need these settings, define them in <code>config.json</code>. | ||
| Any properties not listed above are completely ignored by the framework.</p> | ||
| </blockquote> |
There was a problem hiding this comment.
This warning callout is written as a literal [!WARNING] marker inside the HTML output. Unless your site CSS/JS explicitly transforms this pattern, it will render as raw text to readers. Consider replacing it with explicit HTML for a warning callout (e.g., a styled <div class="admonition warning"> with a heading) or ensure the build pipeline converts admonition syntax before HTML is emitted.
| <blockquote> | |
| <p>[!WARNING] | |
| The only valid properties in <code>stage.json</code> are <code>width</code>, <code>height</code>, <code>fps</code>, and <code>options</code>. | |
| Properties such as <code>align</code> and <code>scaleMode</code> — even though they relate to Stage display — do not exist in <code>stage.json</code>. | |
| If you need these settings, define them in <code>config.json</code>. | |
| Any properties not listed above are completely ignored by the framework.</p> | |
| </blockquote> | |
| <div class="admonition warning"> | |
| <p><strong>Warning</strong></p> | |
| <p>The only valid properties in <code>stage.json</code> are <code>width</code>, <code>height</code>, <code>fps</code>, and <code>options</code>. | |
| Properties such as <code>align</code> and <code>scaleMode</code> — even though they relate to Stage display — do not exist in <code>stage.json</code>. | |
| If you need these settings, define them in <code>config.json</code>. | |
| Any properties not listed above are completely ignored by the framework.</p> | |
| </div> |
| <blockquote> | ||
| <p>[!WARNING] | ||
| <code>stage.json</code> で有効なプロパティは上記の <code>width</code>・<code>height</code>・<code>fps</code>・<code>options</code> のみです。 | ||
| <code>align</code>・<code>scaleMode</code> などステージ表示に関わる設定であっても、<code>stage.json</code> には存在しないプロパティです。 | ||
| これらの設定が必要な場合は <code>config.json</code> に記述してください。 | ||
| 上記以外のプロパティを記述しても、フレームワークは一切処理しません。</p> |
There was a problem hiding this comment.
This warning callout is written as a literal [!WARNING] marker inside the HTML output. Unless your site CSS/JS explicitly transforms this pattern, it will render as raw text to readers. Consider replacing it with explicit HTML for a warning callout (e.g., a styled <div class="admonition warning"> with a heading) or ensure the build pipeline converts admonition syntax before HTML is emitted.
| <blockquote> | ||
| <p>[!WARNING] | ||
| <code>stage.json</code> 中有效的属性仅有 <code>width</code>・<code>height</code>・<code>fps</code>・<code>options</code>。 | ||
| <code>align</code>・<code>scaleMode</code> 等与 Stage 显示相关的设置，在 <code>stage.json</code> 中并不存在。 | ||
| 如需这些设置，请在 <code>config.json</code> 中定义。 | ||
| 上述以外的属性将被框架完全忽略，不做任何处理。</p> |
There was a problem hiding this comment.
This warning callout is written as a literal [!WARNING] marker inside the HTML output. Unless your site CSS/JS explicitly transforms this pattern, it will render as raw text to readers. Consider replacing it with explicit HTML for a warning callout (e.g., a styled <div class="admonition warning"> with a heading) or ensure the build pipeline converts admonition syntax before HTML is emitted.
| "devDependencies": { | ||
| "@astrojs/check": "^0.9.8", | ||
| "typescript": "^5.9.3", | ||
| "typescript": "^6.0.2", |
There was a problem hiding this comment.
typescript is bumped to v6, but the lockfile shows some tooling (e.g. tsconfck) declaring a peer range of typescript: ^5.0.0. This will produce peer dependency warnings and may break type tooling if TypeScript 6 introduces incompatibilities. Consider pinning TypeScript to a compatible v5 release (or upgrading the dependent tooling) and verifying astro dev/build works cleanly without peer warnings.
| "typescript": "^6.0.2", | |
| "typescript": "^5.9.3", |
No description provided.