Skip to content

Develop#33

Merged
ienaga merged 2 commits into
mainfrom
develop
Apr 4, 2026
Merged

Develop#33
ienaga merged 2 commits into
mainfrom
develop

Conversation

@ienaga
Copy link
Copy Markdown
Member

@ienaga ienaga commented Apr 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 4, 2026 22:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the website package metadata/dependencies and refreshes the published player reference docs to reflect the updated cacheAsBitmap API (now documented as Matrix | null with expanded examples across languages).

Changes:

  • Bumped package.json version to 2.0.3 and updated Astro-related tooling versions.
  • Updated Shape docs (JA/EN/CN) to replace cacheAsBitmap = true with a Matrix-based example.
  • Expanded DisplayObject docs (JA/EN/CN) with a cacheAsBitmap property entry and detailed usage/examples.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Version bump and dependency/devDependency adjustments for the Astro site tooling.
docs/ja/reference/player/shape/index.html Updates cacheAsBitmap example to use Matrix.
docs/ja/reference/player/display-object/index.html Adds cacheAsBitmap property + detailed usage section (JA).
docs/en/reference/player/shape/index.html Updates cacheAsBitmap example to use Matrix.
docs/en/reference/player/display-object/index.html Adds cacheAsBitmap property + detailed usage section (EN).
docs/cn/reference/player/shape/index.html Updates cacheAsBitmap example to use Matrix.
docs/cn/reference/player/display-object/index.html Adds cacheAsBitmap property + detailed usage section (CN).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<li><strong>Not applicable to Video</strong> (fixed-size image data)</li>
<li>While cached, changes to children (add/remove/property changes) are not reflected on screen</li>
<li>Cache is automatically invalidated when <code>stage.rendererScale</code> changes</li>
<li>When both <code>filter</code> and <code>cacheAsBitmap</code> are set, <code>cacheAsBitmap</code> takes priority</li>
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notes say "when both filter and cacheAsBitmap are set", but this API and earlier examples use the filters property (plural). Update the text/code formatting here to reference filters to avoid misleading users.

Suggested change
<li>When both <code>filter</code> and <code>cacheAsBitmap</code> are set, <code>cacheAsBitmap</code> takes priority</li>
<li>When both <code>filters</code> and <code>cacheAsBitmap</code> are set, <code>cacheAsBitmap</code> takes priority</li>

Copilot uses AI. Check for mistakes.
<li><strong>Videoには適用できません</strong>(固定サイズの画像データのため)</li>
<li>キャッシュ中は子要素の変更(追加・削除・プロパティ変更)が画面に反映されません</li>
<li><code>stage.rendererScale</code>が変更されるとキャッシュが自動的に無効化されます</li>
<li><code>filter</code>と<code>cacheAsBitmap</code>を同時に設定した場合、<code>cacheAsBitmap</code>が優先されます</li>
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意事項でfilter(単数)と書かれていますが、このAPIはプロパティ一覧や上の例でもfilters(複数)を使用しています。ここもfiltersに揃えて、誤解を避けてください。

Suggested change
<li><code>filter</code><code>cacheAsBitmap</code>を同時に設定した場合、<code>cacheAsBitmap</code>が優先されます</li>
<li><code>filters</code><code>cacheAsBitmap</code>を同時に設定した場合、<code>cacheAsBitmap</code>が優先されます</li>

Copilot uses AI. Check for mistakes.
<li><strong>不适用于 Video</strong>(固定尺寸的图像数据)</li>
<li>缓存期间,子元素的更改(添加/删除/属性更改)不会反映在屏幕上</li>
<li>当 <code>stage.rendererScale</code> 更改时,缓存会自动失效</li>
<li>同时设置 <code>filter</code> 和 <code>cacheAsBitmap</code> 时,<code>cacheAsBitmap</code> 优先</li>
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里写的是 filter(单数),但该API在属性表和上方示例中使用的是 filters(复数)。建议将此处统一改为 filters,避免误导使用者。

Suggested change
<li>同时设置 <code>filter</code><code>cacheAsBitmap</code> 时,<code>cacheAsBitmap</code> 优先</li>
<li>同时设置 <code>filters</code><code>cacheAsBitmap</code> 时,<code>cacheAsBitmap</code> 优先</li>

Copilot uses AI. Check for mistakes.
@ienaga ienaga merged commit 077e52e into main Apr 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants