Skip to content

Update README.md#6

Open
akshitadixit wants to merge 1 commit into
Nexmo:mainfrom
akshitadixit:main
Open

Update README.md#6
akshitadixit wants to merge 1 commit into
Nexmo:mainfrom
akshitadixit:main

Conversation

@akshitadixit
Copy link
Copy Markdown

Changed all references from Nexmo->Vonage. However references to shield links haven't changed. Please let me know about errors.
Closes #2

Changed all references from Nexmo->Vonage
Comment thread README.md
@@ -1,2 +1,134 @@
# vonage-spring-boot-starter-java
Spring Boot Starter for Vonage
# vonage Spring Boot Starter
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "v" in vonage should be capitalized. Also add the world "Java" to the ends so that it matches the name of the project.

Comment thread README.md

<img src="https://developer.nexmo.com/assets/images/Vonage_Nexmo.svg" height="48px" alt="Nexmo is now known as Vonage" />

This Spring Boot Starter has been provided to help with integrating the [Nexmo Java SDK](https://github.com/Nexmo/Nexmo-java) into your [Spring Boot](https://spring.io/projects/spring-boot) project.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link title should change from "Nexmo Java SDK" to "Vonage Java Server SDK"

Comment thread README.md
* [Installation](#installation)
* [Usage](#usage)
* [Customizing the VonageClient](#customizing-the-vonageclient)
* [Customize vonage Client Version](#customize-vonage-client-version)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "v" in vonage should be capitalized.

Comment thread README.md
}

dependencies {
implementation 'com.vonage:vonage-spring-boot-starter:1.1.0'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change com.vonage:vonage-spring-boot-starter:1.1.0 to com.vonage:vonage-spring-boot-starter:1.0.0

Comment thread README.md
<dependency>
<groupId>com.vonage</groupId>
<artifactId>vonage-spring-boot-starter</artifactId>
<version>1.1.0</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version should be 1.0.0

Comment thread README.md

## Customize vonage Client Version

By default, the Vonage Spring Boot Starter will transitively define Vonage Client to the latest version at its release. You can override this by adding a dependency on the Vonage Client, bringing in `4.2.0` for example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of the dependency is 5.5.0

Comment thread README.md
}

dependencies {
implementation 'com.vonage:client:4.2.0'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of the dependency is 5.5.0

Comment thread README.md
<dependency>
<groupId>com.vonage</groupId>
<artifactId>client</artifactId>
<version>4.2.0</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of the dependency is 5.5.0

Comment thread README.md

| Vonage Spring Boot Starter | Vonage Java Client |
|---|---|
| v1.0.0 | v4.3.0 |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should only be 1 row entry in the table here. and that should be | v1.0.0 | v5.5.0 | since

Comment thread README.md

Bringing in older versions of the supported Vonage Client, may result in some unforseen consequences and build errors. As a result here is a list of each version targeted by each version of the starter:

| Vonage Spring Boot Starter | Vonage Java Client |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Vonage Spring Boot Starter" to "Vonage Spring Boot Starter Java"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the README file

2 participants