Skip to content

Default addGeneratedAnnotation and disableDatesInGeneratedAnnotation to true #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiholee17 merged 7 commits into from
Apr 29, 2026
Merged

Default addGeneratedAnnotation and disableDatesInGeneratedAnnotation to true #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a9f5c9
Default addGeneratedAnnotation and disableDatesInGeneratedAnnotation …
jiholee17 Apr 23, 2026
5c68390
Add tests verifying generated flag false
jiholee17 Apr 23, 2026
9202ac4
Detect jakarta annotation-api to conditionally emit @Generated
jiholee17 Apr 24, 2026
84be731
Detect compileclasspath by name to support user-defined tasks
jiholee17 Apr 27, 2026
554df54
Revert jakarta annotation detection changes
jiholee17 Apr 28, 2026
ef2fcd9
Add generatedAnnotationType paramter defaulted to DGS Generated annot…
jiholee17 Apr 28, 2026
b1ecf30
Remove jakarta annotation dependency from gradle tests
jiholee17 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions ...kotlin/com/netflix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/DgsClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.cli
import graphql.language.OperationDefinition
import kotlin.String

@Generated
public object DgsClient {
public fun buildQuery(inputValueSerializer: InputValueSerializerInterface? = null,
_projection: QueryProjection.() -> QueryProjection): String =
Expand Down
5 changes: 5 additions & 0 deletions ...lin/com/netflix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/DgsConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,23 @@ package com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected

import kotlin.String

@Generated
public object DgsConstants {
public const val QUERY_TYPE: String = "Query"

@Generated
public object QUERY {
public const val TYPE_NAME: String = "Query"

public const val People: String = "people"

@Generated
public object PEOPLE_INPUT_ARGUMENT {
public const val Filter: String = "filter"
}
}

@Generated
public object PERSON {
public const val TYPE_NAME: String = "Person"

Expand All @@ -23,6 +27,7 @@ public object DgsConstants {
public const val Lastname: String = "lastname"
}

@Generated
public object PERSONFILTER {
public const val TYPE_NAME: String = "PersonFilter"

Expand Down
7 changes: 7 additions & 0 deletions ...kotlin/com/netflix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/Generated.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected

import kotlin.`annotation`.AnnotationRetention
import kotlin.`annotation`.Retention

@Retention(value = AnnotationRetention.BINARY)
public annotation class Generated
2 changes: 2 additions & 0 deletions ...flix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/client/PersonProjection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.cl

import com.netflix.graphql.dgs.client.codegen.InputValueSerializerInterface
import com.netflix.graphql.dgs.codegen.GraphQLProjection
import com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.Generated

@Generated
public class PersonProjection(
inputValueSerializer: InputValueSerializerInterface? = null,
) : GraphQLProjection(inputValueSerializer) {
Expand Down
2 changes: 2 additions & 0 deletions ...tflix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/client/QueryProjection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ package com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.cl

import com.netflix.graphql.dgs.client.codegen.InputValueSerializerInterface
import com.netflix.graphql.dgs.codegen.GraphQLProjection
import com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.Generated
import com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.types.PersonFilter
import kotlin.String

@Generated
public class QueryProjection(
inputValueSerializer: InputValueSerializerInterface? = null,
) : GraphQLProjection(inputValueSerializer) {
Expand Down
4 changes: 4 additions & 0 deletions ...lin/com/netflix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/types/Person.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import com.fasterxml.jackson.`annotation`.JsonProperty
import com.fasterxml.jackson.`annotation`.JsonTypeInfo
import com.fasterxml.jackson.databind.`annotation`.JsonDeserialize
import com.fasterxml.jackson.databind.`annotation`.JsonPOJOBuilder
import com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.Generated
import java.lang.IllegalStateException
import kotlin.String
import kotlin.jvm.JvmName

@Generated
@JsonTypeInfo(use = JsonTypeInfo.Id.NONE)
@JsonDeserialize(builder = Person.Builder::class)
public class Person(
Expand All @@ -27,6 +29,7 @@ public class Person(
public val lastname: String?
get() = __lastname.invoke()

@Generated
public companion object {
private val firstnameDefault: () -> String? =
{ throw IllegalStateException("Field `firstname` was not requested") }
Expand All @@ -35,6 +38,7 @@ public class Person(
{ throw IllegalStateException("Field `lastname` was not requested") }
}

@Generated
@JsonPOJOBuilder
@JsonIgnoreProperties("__typename")
public class Builder {
Expand Down
2 changes: 2 additions & 0 deletions ...m/netflix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/types/PersonFilter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ package com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.ty

import com.fasterxml.jackson.`annotation`.JsonProperty
import com.netflix.graphql.dgs.codegen.GraphQLInput
import com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.Generated
import kotlin.Any
import kotlin.Pair
import kotlin.String
import kotlin.collections.List

@Generated
public data class PersonFilter(
@JsonProperty("email")
public val email: String? = default<PersonFilter, String?>("email", null),
Expand Down
4 changes: 4 additions & 0 deletions ...tlin/com/netflix/graphql/dgs/codegen/cases/constantsForInputTypes/expected/types/Query.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import com.fasterxml.jackson.`annotation`.JsonProperty
import com.fasterxml.jackson.`annotation`.JsonTypeInfo
import com.fasterxml.jackson.databind.`annotation`.JsonDeserialize
import com.fasterxml.jackson.databind.`annotation`.JsonPOJOBuilder
import com.netflix.graphql.dgs.codegen.cases.constantsForInputTypes.expected.Generated
import java.lang.IllegalStateException
import kotlin.collections.List
import kotlin.jvm.JvmName

@Generated
@JsonTypeInfo(use = JsonTypeInfo.Id.NONE)
@JsonDeserialize(builder = Query.Builder::class)
public class Query(
Expand All @@ -20,11 +22,13 @@ public class Query(
public val people: List<Person?>?
get() = __people.invoke()

@Generated
public companion object {
private val peopleDefault: () -> List<Person?>? =
{ throw IllegalStateException("Field `people` was not requested") }
}

@Generated
@JsonPOJOBuilder
@JsonIgnoreProperties("__typename")
public class Builder {
Expand Down
1 change: 1 addition & 0 deletions ...m/netflix/graphql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/DgsClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.exp
import graphql.language.OperationDefinition
import kotlin.String

@Generated
public object DgsClient {
public fun buildQuery(inputValueSerializer: InputValueSerializerInterface? = null,
_projection: QueryProjection.() -> QueryProjection): String =
Expand Down
5 changes: 5 additions & 0 deletions ...etflix/graphql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/DgsConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,23 @@ package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.ex

import kotlin.String

@Generated
public object DgsConstants {
public const val QUERY_TYPE: String = "Query"

@Generated
public object QUERY {
public const val TYPE_NAME: String = "Query"

public const val People: String = "people"

@Generated
public object PEOPLE_INPUT_ARGUMENT {
public const val Filter: String = "filter"
}
}

@Generated
public object PERSON {
public const val TYPE_NAME: String = "Person"

Expand All @@ -23,6 +27,7 @@ public object DgsConstants {
public const val Lastname: String = "lastname"
}

@Generated
public object PERSONFILTER {
public const val TYPE_NAME: String = "PersonFilter"

Expand Down
7 changes: 7 additions & 0 deletions ...m/netflix/graphql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/Generated.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.expected

import kotlin.`annotation`.AnnotationRetention
import kotlin.`annotation`.Retention

@Retention(value = AnnotationRetention.BINARY)
public annotation class Generated
2 changes: 2 additions & 0 deletions ...hql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/client/PersonProjection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.ex

import com.netflix.graphql.dgs.client.codegen.InputValueSerializerInterface
import com.netflix.graphql.dgs.codegen.GraphQLProjection
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.expected.Generated

@Generated
public class PersonProjection(
inputValueSerializer: InputValueSerializerInterface? = null,
) : GraphQLProjection(inputValueSerializer) {
Expand Down
2 changes: 2 additions & 0 deletions ...phql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/client/QueryProjection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.ex

import com.netflix.graphql.dgs.client.codegen.InputValueSerializerInterface
import com.netflix.graphql.dgs.codegen.GraphQLProjection
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.expected.Generated
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.expected.types.PersonFilter
import kotlin.String

@Generated
public class QueryProjection(
inputValueSerializer: InputValueSerializerInterface? = null,
) : GraphQLProjection(inputValueSerializer) {
Expand Down
4 changes: 4 additions & 0 deletions ...etflix/graphql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/types/Person.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import com.fasterxml.jackson.`annotation`.JsonProperty
import com.fasterxml.jackson.`annotation`.JsonTypeInfo
import com.fasterxml.jackson.databind.`annotation`.JsonDeserialize
import com.fasterxml.jackson.databind.`annotation`.JsonPOJOBuilder
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.expected.Generated
import java.lang.IllegalStateException
import kotlin.String
import kotlin.jvm.JvmName

@Generated
@JsonTypeInfo(use = JsonTypeInfo.Id.NONE)
@JsonDeserialize(builder = Person.Builder::class)
public class Person(
Expand All @@ -27,6 +29,7 @@ public class Person(
public val lastname: String?
get() = __lastname.invoke()

@Generated
public companion object {
private val firstnameDefault: () -> String? =
{ throw IllegalStateException("Field `firstname` was not requested") }
Expand All @@ -35,6 +38,7 @@ public class Person(
{ throw IllegalStateException("Field `lastname` was not requested") }
}

@Generated
@JsonPOJOBuilder
@JsonIgnoreProperties("__typename")
public class Builder {
Expand Down
2 changes: 2 additions & 0 deletions .../graphql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/types/PersonFilter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.ex

import com.fasterxml.jackson.`annotation`.JsonProperty
import com.netflix.graphql.dgs.codegen.GraphQLInput
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.expected.Generated
import kotlin.Any
import kotlin.Int
import kotlin.Pair
import kotlin.String
import kotlin.collections.List

@Generated
public data class PersonFilter(
@JsonProperty("email")
public val email: String? = default<PersonFilter, String?>("email", null),
Expand Down
4 changes: 4 additions & 0 deletions ...netflix/graphql/dgs/codegen/cases/constantsWithExtendedInputTypes/expected/types/Query.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import com.fasterxml.jackson.`annotation`.JsonProperty
import com.fasterxml.jackson.`annotation`.JsonTypeInfo
import com.fasterxml.jackson.databind.`annotation`.JsonDeserialize
import com.fasterxml.jackson.databind.`annotation`.JsonPOJOBuilder
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInputTypes.expected.Generated
import java.lang.IllegalStateException
import kotlin.collections.List
import kotlin.jvm.JvmName

@Generated
@JsonTypeInfo(use = JsonTypeInfo.Id.NONE)
@JsonDeserialize(builder = Query.Builder::class)
public class Query(
Expand All @@ -20,11 +22,13 @@ public class Query(
public val people: List<Person?>?
get() = __people.invoke()

@Generated
public companion object {
private val peopleDefault: () -> List<Person?>? =
{ throw IllegalStateException("Field `people` was not requested") }
}

@Generated
@JsonPOJOBuilder
@JsonIgnoreProperties("__typename")
public class Builder {
Expand Down
1 change: 1 addition & 0 deletions ...om/netflix/graphql/dgs/codegen/cases/constantsWithExtendedInterface/expected/DgsClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.expe
import graphql.language.OperationDefinition
import kotlin.String

@Generated
public object DgsClient {
public fun buildQuery(inputValueSerializer: InputValueSerializerInterface? = null,
_projection: QueryProjection.() -> QueryProjection): String =
Expand Down
3 changes: 3 additions & 0 deletions ...netflix/graphql/dgs/codegen/cases/constantsWithExtendedInterface/expected/DgsConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@ package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.exp

import kotlin.String

@Generated
public object DgsConstants {
public const val QUERY_TYPE: String = "Query"

@Generated
public object QUERY {
public const val TYPE_NAME: String = "Query"

public const val People: String = "people"
}

@Generated
public object PERSON {
public const val TYPE_NAME: String = "Person"

Expand Down
7 changes: 7 additions & 0 deletions ...om/netflix/graphql/dgs/codegen/cases/constantsWithExtendedInterface/expected/Generated.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.expected

import kotlin.`annotation`.AnnotationRetention
import kotlin.`annotation`.Retention

@Retention(value = AnnotationRetention.BINARY)
public annotation class Generated
2 changes: 2 additions & 0 deletions ...phql/dgs/codegen/cases/constantsWithExtendedInterface/expected/client/PersonProjection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.exp

import com.netflix.graphql.dgs.client.codegen.InputValueSerializerInterface
import com.netflix.graphql.dgs.codegen.GraphQLProjection
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.expected.Generated

@Generated
public class PersonProjection(
inputValueSerializer: InputValueSerializerInterface? = null,
) : GraphQLProjection(inputValueSerializer) {
Expand Down
2 changes: 2 additions & 0 deletions ...aphql/dgs/codegen/cases/constantsWithExtendedInterface/expected/client/QueryProjection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.exp

import com.netflix.graphql.dgs.client.codegen.InputValueSerializerInterface
import com.netflix.graphql.dgs.codegen.GraphQLProjection
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.expected.Generated
import kotlin.String

@Generated
public class QueryProjection(
inputValueSerializer: InputValueSerializerInterface? = null,
) : GraphQLProjection(inputValueSerializer) {
Expand Down
2 changes: 2 additions & 0 deletions ...netflix/graphql/dgs/codegen/cases/constantsWithExtendedInterface/expected/types/Person.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
package com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.expected.types

import com.fasterxml.jackson.`annotation`.JsonTypeInfo
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.expected.Generated
import kotlin.Int
import kotlin.String
import kotlin.Suppress
import kotlin.jvm.JvmName

@Generated
@JsonTypeInfo(
use = JsonTypeInfo.Id.NAME,
include = JsonTypeInfo.As.PROPERTY,
Expand Down
4 changes: 4 additions & 0 deletions .../netflix/graphql/dgs/codegen/cases/constantsWithExtendedInterface/expected/types/Query.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import com.fasterxml.jackson.`annotation`.JsonProperty
import com.fasterxml.jackson.`annotation`.JsonTypeInfo
import com.fasterxml.jackson.databind.`annotation`.JsonDeserialize
import com.fasterxml.jackson.databind.`annotation`.JsonPOJOBuilder
import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedInterface.expected.Generated
import java.lang.IllegalStateException
import kotlin.collections.List
import kotlin.jvm.JvmName

@Generated
@JsonTypeInfo(use = JsonTypeInfo.Id.NONE)
@JsonDeserialize(builder = Query.Builder::class)
public class Query(
Expand All @@ -20,11 +22,13 @@ public class Query(
public val people: List<Person?>?
get() = __people.invoke()

@Generated
public companion object {
private val peopleDefault: () -> List<Person?>? =
{ throw IllegalStateException("Field `people` was not requested") }
}

@Generated
@JsonPOJOBuilder
@JsonIgnoreProperties("__typename")
public class Builder {
Expand Down
1 change: 1 addition & 0 deletions ...in/com/netflix/graphql/dgs/codegen/cases/constantsWithExtendedQuery/expected/DgsClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.netflix.graphql.dgs.codegen.cases.constantsWithExtendedQuery.expected
import graphql.language.OperationDefinition
import kotlin.String

@Generated
public object DgsClient {
public fun buildQuery(inputValueSerializer: InputValueSerializerInterface? = null,
_projection: QueryProjection.() -> QueryProjection): String =
Expand Down
Loading