Feature: Webhooks for workflow and task status by charybr · Pull Request #228 · Netflix/conductor-community

charybr · 2023-05-24T18:09:03Z

Pull Request type

Bugfix
Feature
Refactoring (no functional changes, no api changes)
Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
WHOSUSING.md
Other (please describe):

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue #212

Webhooks for workflow and task status

Problem:
We have a requirement to publish status of workflow and task to a Webhook.

Approach:
WorkflowStatusListener and TaskStatusListener interfaces can be implemented to call webhooks when there is a change in status of workflow and task. We can add new module called 'webhook'.

This PR is originated from the changes done by @techyragu (Rahul Gupta) done on CiscoM31/conductor CiscoM31/conductor#26.

Alternatives considered

Describe alternative implementation you have considered

conductor-core.

ExecutionDAO indexTask commented out. Workflow to WorkflowModel. indexWorkflow call commented out.

…into feature/webhook

Netflix/conductor#3623 gets merged.

…Notification.

v1r3n · 2023-06-18T16:28:13Z

webhook/src/main/java/com/netflix/conductor/contribs/publisher/TaskNotification.java

+
+    public String workflowTaskType;
+    private String domainGroupMoId = "";
+    private String accountMoId = "";


This seems like an application specific field. The notification should be a generic class.

Thank you Viren for reviewing! Yes, both accountMoId and domainGroupMoId are custom fields. I will work on it and get back.

Hello, this property configuration takes effect when the conductor server is started, but there may be multiple clients using it in practice. Can I set different URLs and endpoint according to different clients?

for example：

thank you Huang! for the comments. i will check if we can build url dynamically.

thank you Huang! for the comments. i will check if we can build url dynamically.

Hi, @charybr ! This is my PR regarding this issue(charybr#1). Could you consider merging?

thats great Huang! Thank you. Give me 3-4 days i will check and merge by this weekend.

Hi Huang, i have merged your PR. thank you!

Hi, how's it going? @charybr

review is pending

Netflix/conductor#3623 merged

…ductor-community into feature/task_webhook

charybr · 2023-08-24T13:58:51Z

Hi @youngledo , your changes were in branch charybr:feature/webhook. I cherry-picked your commits into branch of this PR i.e. charybr:feature/task_webhook.

So please review below commits:
20a609d
42c7ae2

youngledo · 2023-08-28T03:57:56Z

Hi @youngledo , your changes were in branch charybr:feature/webhook. I cherry-picked your commits into branch of this PR i.e. charybr:feature/task_webhook.

So please review below commits: 20a609d 42c7ae2

OK, I've already reviewed it.

manan164 · 2023-10-03T15:49:35Z

Hi @charybr , Please make the below changes,

Remove usage of webhook as it is conflicting with system task webhooks in workflow
Make workflow publisher part of workflow-status-event-listerner module
Add new module task-status-listener and move task status related changes there.

github-actions · 2023-11-18T00:01:11Z

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days.

charybr · 2023-11-20T03:38:38Z

Commenting so that Stale label gets removed. Will work on the review comments in Dec.

Raghavendra Chary B and others added 20 commits April 19, 2023 11:16

Added readme.

892d0ed

Added gradle build files.

312a25f

Added webhook module in gradle files.

2e7f722

Added Publisher related files.

d5c9cd6

Added ConfigProp interface in contribs, as it was removed from

70db9c0

conductor-core.

Added javax.inject dependency explicitly.

9097cbf

TaskStatusListener interface is not present in conductor-core.

314b173

ExecutionDAOFacade package changed from orhestration to dal.

e5c0ab4

Added apache commons-lang3 dependency.

e8c63dc

Added http client dependency.

05dff97

Added conductor-annotations dependecy.

52c432f

ExecutionDAO indexTask commented out. Workflow to WorkflowModel. indexWorkflow call commented out.

Convert WorkflowModel to Workflow.

a469d54

Merge branch 'main' of https://github.com/charybr/conductor-community …

3a7e8eb

…into feature/webhook

Able to build after removing webhook project from dependencies.lock.

d5d0f99

Include only required modules. Jar reduced from 141M to 50M.

c643e9d

Added new config files.

a856d34

Merge branch 'main' of https://github.com/charybr/conductor-community …

4a8bdfd

…into feature/webhook

Uncomment lines that are required for community repo

7ba9608

TaskStatusListener implementation. For now using local libs till

bfbe6a5

Netflix/conductor#3623 gets merged.

Task SCHEDULED status notification going out from conductor.

a6eeb4e

charybr changed the title ~~Feature/task webhook~~ Feature: Webhooks for workflow and task status May 24, 2023

Fix for Error unmarshalling input data.

23352eb

charybr mentioned this pull request May 26, 2023

Feature: Need for Task status listener Netflix/conductor#3623

Merged

6 tasks

Raghavendra Chary B and others added 5 commits May 26, 2023 20:20

Added TBD - config to subscribe for interested Task statuses.

0c4460e

Added config to specify subscribed Task Status list.

f3d556c

Added attributes required for SerialLoop, Fork-Join workflows in Task…

ce62067

…Notification.

TaskNotification - taskDescription should come from WorkflowTask.

521c0ce

Merge branch 'Netflix:main' into feature/task_webhook

6c5a1c4

v1r3n reviewed Jun 18, 2023

View reviewed changes

Remove custom attributes from TaskNotification

2e5a0de

Remove custom attributes from WorkflowNotification

658f703

youngledo mentioned this pull request Jul 11, 2023

Added webhook files. charybr/conductor-community#1

Merged

6 tasks

charybr and others added 11 commits July 19, 2023 11:41

TaskStatusListner PR merged to conductor main

78691d0

Netflix/conductor#3623 merged

Merge branch 'Netflix:main' into feature/task_webhook

3642e2b

Merge branch 'Netflix:main' into feature/task_webhook

a4a22dc

Removed references to custom attributes.

51a13b6

Merge branch 'feature/task_webhook' of https://github.com/charybr/con…

412fabe

…ductor-community into feature/task_webhook

Remove local_lib reference.

809c68b

Update conductor version

fd44c24

Merge branch 'Netflix:main' into feature/task_webhook

1aa24ed

Added webhook files.

20a609d

Fix variable error

42c7ae2

Merge branch 'feature/task_webhook' of https://github.com/charybr/con…

27c3a0e

…ductor-community into feature/task_webhook

Merge branch 'Netflix:main' into feature/task_webhook

2eee92e

charybr mentioned this pull request Sep 28, 2023

Feature/webhook #222

Closed

6 tasks

Merge branch 'Netflix:main' into feature/task_webhook

b00755b

github-actions bot added the Stale label Nov 18, 2023

github-actions bot removed the Stale label Nov 21, 2023

CollinDewey mentioned this pull request Apr 2, 2024

Feature: Webhooks for Workflow and Task Statuses conductor-oss/conductor#115

Merged

6 tasks

Conversation

charybr commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request type

Changes in this PR

Alternatives considered

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youngledo Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youngledo Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charybr commented Aug 24, 2023

Uh oh!

youngledo commented Aug 28, 2023

Uh oh!

manan164 commented Oct 3, 2023

Uh oh!

github-actions bot commented Nov 18, 2023

Uh oh!

charybr commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

charybr commented May 24, 2023 •

edited

Loading

youngledo Jun 28, 2023 •

edited

Loading

youngledo Aug 24, 2023 •

edited

Loading