make listDelimiter volatile#767
Open
sahvx655-wq wants to merge 1 commit into
Open
Conversation
listDelimiter is mutated through setListDelimiter and read concurrently via getListDelimiter, but was left non-volatile when decoder and interpolator were marked volatile. without it a write has no happens-before with reads on other threads, so stale values can be observed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reading the change that made decoder and interpolator volatile, listDelimiter is the third setter-backed field in AbstractConfig with the same shape: setListDelimiter writes it and getListDelimiter reads it (CommonsToConfig joins on it from the read path). it was missed, so a write still has no happens-before with reads on other threads and a stale delimiter can be observed indefinitely. same single-assignment setter, so volatile is the right level here too.