reject malformed map entries in collections type converter#765
Open
sahvx655-wq wants to merge 1 commit into
Open
reject malformed map entries in collections type converter#765sahvx655-wq wants to merge 1 commit into
sahvx655-wq wants to merge 1 commit into
Conversation
Author
|
gentle ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createMapTypeConverter in DefaultCollectionsTypeConverterFactory splits each comma-separated pair on '=' and reads kv[1] without checking the split produced two parts, so a Map property value like
key=12345,bogusthrows ArrayIndexOutOfBoundsException from inside the converter. Reject the malformed entry with a ParseException instead, matching how convertBoolean already rejects unparseable input.