Draft
Conversation
Change output format from TSV to PKL for easypqp for Nesvilab/FragPipe-SpecLib#3
fcyu
requested changes
Jan 25, 2026
Member
fcyu
left a comment
fcyu
left a comment
There was a problem hiding this comment.
Did you test it?
You also need to release a new version of FragPipe-SpecLib since the new changes is needed: Nesvilab/FragPipe-SpecLib#3
And then, update the Python packages and requirements.txt in FragPipe.
Thanks,
Fengchao
Member
Author
|
Tested. |
Member
Author
|
I think there are still more modifications I want to make to FragPipe-SpecLib. So let me finish those before doing the version update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change output format from TSV to PKL for easypqp
for Nesvilab/FragPipe-SpecLib#3