fix: satisfy CSSProperties type for hello-pangea/dnd draggable style#247
Conversation
@radix-ui/react-dialog 1.1.17 augments React.CSSProperties with a
--radix-${string} index signature that DraggingStyle from
@hello-pangea/dnd does not declare, breaking tsc. Cast draggableProps
style to React.CSSProperties at the two spread sites in TestBuilderPage.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesDraggable Style Assignment
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Summary
@radix-ui/react-dialog@1.1.17(introduced in Dependabot PR chore(deps): bump the react-ecosystem group across 1 directory with 3 updates #166) augmentsReact.CSSPropertieswith a--radix-${string}index signature@hello-pangea/dnd'sDraggingStyletype does not declare that index signature, so spreadingdraggablePropsdirectly onto a<div>broketscdraggableProps.styletoReact.CSSPropertiesat the two spread sites inTestBuilderPage.tsx— same pattern already used inRubricBuilder.tsxWhat a reviewer should know
This fix was developed alongside PR #166 (the Dependabot react-ecosystem bump). The same change was pushed directly to that branch so #166's CI could go green; this PR lands the fix on
mainso it persists independently of Dependabot rebase cycles.No runtime behaviour changes — cast only affects TypeScript compilation.
🤖 Generated with Claude Code
Summary by CodeRabbit