Fix games not ending if match is won by hitting score limit #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DESTROYGIRL
added
the
Release priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dont set
m_flNeoNextRoundStartTime = FLT_MAXor else the match end logic is never runI am sleepy. Maybe I am wrong
Testers: Ensure this does not break scenarios like
neo_round_limit=0whereneo_score_limithas a value and vice versa... and maybe check a different gamemode like JGR just to be safeAlso make sure that
m_flNeoNextRoundStartTimewas not set to float max for a proper reason, I assume it was originally there to prevent new rounds starting during the map change?Toolchain
Linked Issues