feat: handling timedelta objects in the FriendlyEncoder class#16
Merged
RobertoPrevato merged 1 commit intoNeoteroi:mainfrom Apr 1, 2025
Merged
feat: handling timedelta objects in the FriendlyEncoder class#16RobertoPrevato merged 1 commit intoNeoteroi:mainfrom
RobertoPrevato merged 1 commit intoNeoteroi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came to an use case in Blacksheep where I needed to return timedelta objects. This timedelta object was inside a Pydantic BaseModel. But I got the error
TypeError: Object of type timedelta is not JSON serializablebecause essentials didn't handle timedelta objects. Leaving this small contrib. Hope it helps others too.Changes:
ifstatement, that checkes ifobjis an instance of atimedeltaobject.