build: Remove Preferences.framework dependency#86
Open
teslamint wants to merge 1 commit into
Open
Conversation
SettingsViewController was superseded by ModernSettingsViewController and had become dead code, but its Preferences.framework consumers were still being compiled and linked. Remove all traces: - Drop PSListController and PSSpecifier imports from Tweak.x - Remove HBForceCepheiPrefs hook from Tweak.x (no target once CepheiPrefs is unlinked) - Drop SettingsViewController.h import from BHTManager.m - Exclude SettingsViewController.m from build via filter-out in Makefile - Remove BHTwitter_PRIVATE_FRAMEWORKS = Preferences from Makefile - Remove BHTwitter_EXTRA_FRAMEWORKS (Cephei, CepheiPrefs, CepheiUI) from Makefile BHTManager already reads all preferences via NSUserDefaults directly and BHTSettingsWithAccount: already returns ModernSettingsViewController, so no behaviour changes. Assisted-by: Claude Sonnet 4.5 via Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SettingsViewController was superseded by ModernSettingsViewController and had become dead code, but its Preferences.framework consumers were still being compiled and linked. Remove all traces:
BHTManager already reads all preferences via NSUserDefaults directly and BHTSettingsWithAccount: already returns ModernSettingsViewController, so no behaviour changes.
Assisted-by: Claude Sonnet 4.5 via Claude Code