Add missing methods for Laurent polynomials#2358
Open
SoongNoonien wants to merge 2 commits intoNemocas:masterfrom
Open
Add missing methods for Laurent polynomials#2358SoongNoonien wants to merge 2 commits intoNemocas:masterfrom
SoongNoonien wants to merge 2 commits intoNemocas:masterfrom
Conversation
SoongNoonien
added
the
release notes: use title
Collaborator
Author
|
Interesting docstring failures... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
==========================================
- Coverage 88.21% 88.20% -0.01%
==========================================
Files 127 127
Lines 32847 32847
==========================================
- Hits 28975 28974 -1
- Misses 3872 3873 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I've talked to @ollieclarke8787 and he would also like to have |
SoongNoonien
force-pushed
the
laurent_functions
branch
2 times, most recently
from
b637ab4 to
36e8789
Compare
SoongNoonien
force-pushed
the
laurent_functions
branch
from
36e8789 to
31af466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking over oscar-system/Oscar.jl#5797 I noticed some missing methods for Laurent polynomials. The PR adds
is_term,is_monomialandlengthconsistently. I also noticed thatsrc/algorithms/LaurentPoly.jlshould actually be merged intosrc/LaurentPoly.jl. Perhaps it could also be good to add some more docstrings.