Change behavior of base_ring for Laurent polynomials#2356
Open
SoongNoonien wants to merge 1 commit intoNemocas:masterfrom
Open
Change behavior of base_ring for Laurent polynomials#2356SoongNoonien wants to merge 1 commit intoNemocas:masterfrom
base_ring for Laurent polynomials#2356SoongNoonien wants to merge 1 commit intoNemocas:masterfrom
Conversation
SoongNoonien
force-pushed
the
laurent_base_ring
branch
3 times, most recently
from
302f2cc to
30f47fe
Compare
SoongNoonien
force-pushed
the
laurent_base_ring
branch
from
30f47fe to
39d8217
Compare
SoongNoonien
added
the
release notes: use title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2356 +/- ##
==========================================
- Coverage 88.21% 88.20% -0.01%
==========================================
Files 127 127
Lines 32847 32847
==========================================
- Hits 28975 28974 -1
- Misses 3872 3873 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2182, this changes the behavior of
base_ringfor Laurent polynomials to return the underlying polynomial ring instead of the coefficient ring.